[GitHub] [iceberg] rdblue commented on a change in pull request #4440: Changing the access modifiers on all the JDBC Static Values

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4440:
URL: https://github.com/apache/iceberg/pull/4440#discussion_r839932905



##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
##########
@@ -32,20 +32,20 @@
 
 final class JdbcUtil {
   // Catalog Table
-  protected static final String CATALOG_TABLE_NAME = "iceberg_tables";
-  protected static final String CATALOG_NAME = "catalog_name";
-  protected static final String TABLE_NAMESPACE = "table_namespace";
-  protected static final String TABLE_NAME = "table_name";
-  protected static final String METADATA_LOCATION = "metadata_location";
-  protected static final String PREVIOUS_METADATA_LOCATION = "previous_metadata_location";
+  public static final String CATALOG_TABLE_NAME = "iceberg_tables";
+  public static final String CATALOG_NAME = "catalog_name";
+  public static final String TABLE_NAMESPACE = "table_namespace";
+  public static final String TABLE_NAME = "table_name";
+  public static final String METADATA_LOCATION = "metadata_location";
+  public static final String PREVIOUS_METADATA_LOCATION = "previous_metadata_location";

Review comment:
       These should not be public. If you are trying to fix a warning, I think the right fix is to make them package-private instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org