You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2021/07/27 04:46:47 UTC
Review Request 73487: RANGER-3351: Incorrect hive query displayed for
grant and revoke role command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73487/
-----------------------------------------------------------
Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
Bugs: RANGER-3351
https://issues.apache.org/jira/browse/RANGER-3351
Repository: ranger
Description
-------
**Problem statement:** After grant and revoke command access audit log does not display the actual executed query correctly:
**Example:**
Grant command : GRANT r4 TO USER user1;
Revoke command : REVOKE r4 from USER user1;
**Expected sql query in access audit log:**
Grant command : GRANT r4 TO USER user1;
Revoke command : REVOKE r4 from USER user1;
**Actual**
Grant command : grant role r4 to USER user1;
Revoke command : revoke role USER user1 from r4;
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 6df0bed1c
Diff: https://reviews.apache.org/r/73487/diff/1/
Testing
-------
Tested patch and after the patch actual statement are for above example:
Grant command : grant r4 to USER user1
Revoke command : revoke r4 from USER user1
Thanks,
Pradeep Agrawal
Re: Review Request 73487: RANGER-3351: Incorrect hive query displayed
for grant and revoke role command
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73487/#review223270
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On July 27, 2021, 4:46 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73487/
> -----------------------------------------------------------
>
> (Updated July 27, 2021, 4:46 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3351
> https://issues.apache.org/jira/browse/RANGER-3351
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem statement:** After grant and revoke command access audit log does not display the actual executed query correctly:
>
> **Example:**
>
> Grant command : GRANT r4 TO USER user1;
> Revoke command : REVOKE r4 from USER user1;
>
> **Expected sql query in access audit log:**
>
> Grant command : GRANT r4 TO USER user1;
> Revoke command : REVOKE r4 from USER user1;
>
> **Actual**
> Grant command : grant role r4 to USER user1;
> Revoke command : revoke role USER user1 from r4;
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 6df0bed1c
>
>
> Diff: https://reviews.apache.org/r/73487/diff/1/
>
>
> Testing
> -------
>
> Tested patch and after the patch actual statement are for above example:
>
> Grant command : grant r4 to USER user1
> Revoke command : revoke r4 from USER user1
>
>
> Thanks,
>
> Pradeep Agrawal
>
>