You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/22 23:31:20 UTC
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9772
to review the following change.
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
build: add support for DATA_FILES in ADD_KUDU_TEST
This adds a new argument to ADD_KUDU_TEST which specifies one or more
data files necessary for running a test. This causes those files to get
copied into the build directory as well as uploaded to dist-test.
Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
---
M CMakeLists.txt
M build-support/dist_test.py
M src/kudu/tablet/CMakeLists.txt
3 files changed, 67 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/9772/1
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@714
PS1, Line 714: # DATA_FILES <file1> <file2> ...
you might note that the multi-arg nature of this is unused in this commit, but it's used in the next commit in this patch series and I figured it would be easier to review separately.
http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt
File src/kudu/tablet/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt@91
PS1, Line 91: ADD_KUDU_TEST(compaction_policy-test DATA_FILES ycsb-test-rowsets.tsv)
The real change is adding the data file here and removing the 'ln -sf' stuff. I re-sorted the tests because I knew Adar would ask me to if I didn't.
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:37:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816
PS1, Line 816: pipe-delimited
> I tried using the original delimiters, but the problem is that the environm
I don't feel strongly, but I just think it's more typical to see colon delimiting (Java classpath) or comma delimiting (most other applications) rather than pipe delimiting, and on the off chance that someone peeks at a /proc/dist-test/environ, it'll surprise them less.
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 00:02:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816
PS1, Line 816: pipe-delimited
Why not just use the original semi-colon delimiters? Or why not comma-delimited or colon-delimited, either of which have some prior art?
http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt
File src/kudu/tablet/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/src/kudu/tablet/CMakeLists.txt@91
PS1, Line 91: ADD_KUDU_TEST(compaction_policy-test DATA_FILES ycsb-test-rowsets.tsv)
> The real change is adding the data file here and removing the 'ln -sf' stuf
The real change was the friends we made along the way.
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:52:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:02:57 +0000
Gerrit-HasComments: No
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816
PS1, Line 816: pipe-delimited
> Why not just use the original semi-colon delimiters? Or why not comma-delim
I tried using the original delimiters, but the problem is that the environment is passed to ctest using a semicolon-delimited list of key=value pairs, so putting a semicolon in the environment variable breaks it...
As for using a colon, that would be fine too. I was afraid if I did that you'd complain that it hampers portability on Windows since it won't support C:\ paths :) But if you like it better, happy to change.
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:57:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9772/1/CMakeLists.txt@816
PS1, Line 816: pipe-delimited
> I don't feel strongly, but I just think it's more typical to see colon deli
Done
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 20:58:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9772
to look at the new patch set (#2).
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
build: add support for DATA_FILES in ADD_KUDU_TEST
This adds a new argument to ADD_KUDU_TEST which specifies one or more
data files necessary for running a test. This causes those files to get
copied into the build directory as well as uploaded to dist-test.
Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
---
M CMakeLists.txt
M build-support/dist_test.py
M src/kudu/tablet/CMakeLists.txt
3 files changed, 66 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/9772/2
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build: add support for DATA FILES in ADD KUDU TEST
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9772 )
Change subject: build: add support for DATA_FILES in ADD_KUDU_TEST
......................................................................
build: add support for DATA_FILES in ADD_KUDU_TEST
This adds a new argument to ADD_KUDU_TEST which specifies one or more
data files necessary for running a test. This causes those files to get
copied into the build directory as well as uploaded to dist-test.
Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Reviewed-on: http://gerrit.cloudera.org:8080/9772
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M build-support/dist_test.py
M src/kudu/tablet/CMakeLists.txt
3 files changed, 66 insertions(+), 30 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcbcb6777761d26e8e0e7634da67b73bbc44b6a6
Gerrit-Change-Number: 9772
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>