You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "bzp2010 (via GitHub)" <gi...@apache.org> on 2025/06/23 10:30:16 UTC
[PR] feat: add apisix dashboard to dev image [apisix]
bzp2010 opened a new pull request, #12369:
URL: https://github.com/apache/apisix/pull/12369
### Description
Build the APISIX dashboard and put it into the dev image.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add apisix dashboard to dev image [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on code in PR #12369:
URL: https://github.com/apache/apisix/pull/12369#discussion_r2161360747
##########
.github/workflows/push-dev-image-on-commit.yml:
##########
@@ -32,6 +32,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v4
+ - name: Build APISIX Dashboard
Review Comment:
I don't feel the need. It's not a standard build and development process, and it doesn't seem to make much sense to package an image.
Users should develop through the apisix-dashboard project, not in apisix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add apisix dashboard to dev image [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 merged PR #12369:
URL: https://github.com/apache/apisix/pull/12369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add apisix dashboard to dev image [apisix]
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung commented on code in PR #12369:
URL: https://github.com/apache/apisix/pull/12369#discussion_r2161349263
##########
.github/workflows/push-dev-image-on-commit.yml:
##########
@@ -32,6 +32,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v4
+ - name: Build APISIX Dashboard
Review Comment:
Should a Makefile command be written for users to build locally themselves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org