You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/02/11 16:10:56 UTC

[kudu-CR] [examples] Add a quickstart guide for YCSB

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15204


Change subject: [examples] Add a quickstart guide for YCSB
......................................................................

[examples] Add a quickstart guide for YCSB

Adds a brief quickstart guide to show the steps to run YCSB
against a Kudu cluster.

Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
---
M examples/quickstart/ycsb/README.adoc
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15204/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15204

to look at the new patch set (#3).

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................

[examples] Add a quickstart guide for YCSB

Adds a brief quickstart guide to show the steps to run YCSB
against a Kudu cluster.

Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
---
A examples/quickstart/ycsb/README.adoc
1 file changed, 98 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15204/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Patch Set 2:

(3 comments)

Thank you for adding this new document!

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc
File examples/quickstart/ycsb/README.adoc:

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@30
PS2, Line 30: 
Maybe, add another option to build Kudu from source and then use $KUDU_ROOT/src/kudu/scripts/start_kudu.sh scripts to start  Kudu cluster?


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@38
PS2, Line 38: -O --location
nit: maybe, use the same option notation for both flags?  I.e., either '-LO' (short notation) or '--location --remote-name'


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@39
PS2, Line 39: xfvz
nit: xfv (drop 'z' since it's not needed here)



-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 18:50:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15204

to look at the new patch set (#2).

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................

[examples] Add a quickstart guide for YCSB

Adds a brief quickstart guide to show the steps to run YCSB
against a Kudu cluster.

Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
---
A examples/quickstart/ycsb/README.adoc
1 file changed, 98 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15204/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc
File examples/quickstart/ycsb/README.adoc:

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@30
PS2, Line 30: 
> Maybe, add another option to build Kudu from source and then use $KUDU_ROOT
These guides under the quickstart directory are targeted at the quickstart cluster. I fully expect users to run YCSB against other types of clusters too which is why I put the "NOTE" above.


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@38
PS2, Line 38: -O --location
> nit: maybe, use the same option notation for both flags?  I.e., either '-LO
Done


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@39
PS2, Line 39: xfvz
> nit: xfv (drop 'z' since it's not needed here)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 18:54:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 19:01:28 +0000
Gerrit-HasComments: No

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 18:22:13 +0000
Gerrit-HasComments: No

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a quickstart guide for YCSB

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................

[examples] Add a quickstart guide for YCSB

Adds a brief quickstart guide to show the steps to run YCSB
against a Kudu cluster.

Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Reviewed-on: http://gerrit.cloudera.org:8080/15204
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
A examples/quickstart/ycsb/README.adoc
1 file changed, 98 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)