You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@codehaus.org> on 2009/11/17 21:08:55 UTC
[jira] Created: (SCM-509) Tagging fails to use provided message
while checking in works fine
Tagging fails to use provided message while checking in works fine
------------------------------------------------------------------
Key: SCM-509
URL: http://jira.codehaus.org/browse/SCM-509
Project: Maven SCM
Issue Type: Bug
Components: maven-scm-api
Affects Versions: 1.2
Reporter: Robert Scholte
Priority: Critical
During a mvn prepare:release there are 3 scm-action: checking in release pom, tagging, checking in pom for next snapshot. Both the checkins have a message starting with [maven-release-plugin], while the tag the the default message [maven-scm]
After some investigation it seems like it works like this for ages although according to the code the attempt is to give them all the same prefix.
Compare these changelogs for example
* http://fisheye.codehaus.org/changelog/qdox/?cs=664
* http://fisheye.codehaus.org/changelog/qdox/?cs=665
* http://fisheye.codehaus.org/changelog/qdox/?cs=666
For me it's critical, because with a current project our SVN system has a prehook which requires every message to start with BugID: {theId}.
I thought I found it, but cheered a bit too early.
The {{org.apache.maven.scm.command.tag.AbstractTagCommand}} is responsible for the default message.
It seems like {{parameters.getScmTagParameters( CommandParameter.SCM_TAG_PARAMETERS );}} was empty, so it returned an empty {{ScmTagParameter}}
These params were created at {{org.apache.maven.shared.release.phase.ScmTagPhase}} and {{org.apache.maven.scm.provider.AbstractScmProvider}} adds them to the CommandParameters.
Somewhere around here something goes wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SCM-509) Tagging fails to use provided message
while checking in works fine
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed SCM-509.
------------------------------
Resolution: Duplicate
Fix Version/s: 1.3
Hmm, this explains it SCM-460
> Tagging fails to use provided message while checking in works fine
> ------------------------------------------------------------------
>
> Key: SCM-509
> URL: http://jira.codehaus.org/browse/SCM-509
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api
> Affects Versions: 1.2
> Reporter: Robert Scholte
> Priority: Critical
> Fix For: 1.3
>
>
> During a mvn prepare:release there are 3 scm-action: checking in release pom, tagging, checking in pom for next snapshot. Both the checkins have a message starting with [maven-release-plugin], while the tag the the default message [maven-scm]
> After some investigation it seems like it works like this for ages although according to the code the attempt is to give them all the same prefix.
> Compare these changelogs for example
> * http://fisheye.codehaus.org/changelog/qdox/?cs=664
> * http://fisheye.codehaus.org/changelog/qdox/?cs=665
> * http://fisheye.codehaus.org/changelog/qdox/?cs=666
> For me it's critical, because with a current project our SVN system has a prehook which requires every message to start with BugID: {theId}.
> I thought I found it, but cheered a bit too early.
> The {{org.apache.maven.scm.command.tag.AbstractTagCommand}} is responsible for the default message.
> It seems like {{parameters.getScmTagParameters( CommandParameter.SCM_TAG_PARAMETERS );}} was empty, so it returned an empty {{ScmTagParameter}}
> These params were created at {{org.apache.maven.shared.release.phase.ScmTagPhase}} and {{org.apache.maven.scm.provider.AbstractScmProvider}} adds them to the CommandParameters.
> Somewhere around here something goes wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira