You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/10 11:05:45 UTC

[GitHub] [ozone] JacksonYao287 opened a new pull request #2325: HDDS-5329. remove lockmanager and synchronize on containerinfo in rep…

JacksonYao287 opened a new pull request #2325:
URL: https://github.com/apache/ozone/pull/2325


   …lication manager
   
   ## What changes were proposed in this pull request?
   
   ReplicationManager has a LockManager object that creates locks based on the ContainerInfo.getContainerID().However, this lockManager is not shared with other classes in SCM. It seems to be passed into only RM.When processing a container, RM locks using this.ICRs and FCRs can change the replicas and details stored in ContainerInfo and they lock a container using synchronized(containerInfo) while processing that Container in the report.As RM and ICR/FCR use different locks the locks do not protect against changes in each other.
   
   this PR aims to remove LockManager from RM and just make it synchronize on the containerInfo object it is processing. 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5329
   
   ## How was this patch tested?
   
   unit test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on pull request #2325: HDDS-5329. remove lockmanager and synchronize on containerinfo in replication manager

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2325:
URL: https://github.com/apache/ozone/pull/2325#issuecomment-859188607


   > I am +1 on this change. While I have never seen a race condition caused by the issue highlighted here, I think it is possible.
   > I will not commit this for another day to give others a chance to check it in case anyone disagrees.
   
   Thanks @sodonnel for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on pull request #2325: HDDS-5329. remove lockmanager and synchronize on containerinfo in replication manager

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2325:
URL: https://github.com/apache/ozone/pull/2325#issuecomment-858532739


   @sodonnel PTAL, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] sodonnel merged pull request #2325: HDDS-5329. remove lockmanager and synchronize on containerinfo in replication manager

Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #2325:
URL: https://github.com/apache/ozone/pull/2325


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org