You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/07/06 01:51:10 UTC

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

Hello Henry Robinson, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10760

to look at the new patch set (#2).

Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................

IMPALA-4669: [KRPC] Add kudu_rpc library to build

Import FindKRPC.cmake from Apache Kudu.

Add some files to protoc-gen-krpc link to allow it to find symbols now
defined within Impala (without linking all of Impala's libraries).

Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Reviewed-on: http://gerrit.cloudera.org:8080/5719
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/rpc-mgr-test-base.h
M be/src/runtime/krpc-data-stream-mgr.cc
4 files changed, 13 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10760/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5693288db90f2e9673b8c88ca4378c3790cba957
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>