You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/04 21:44:29 UTC
[GitHub] [beam] reuvenlax opened a new pull request #11046: [BEAM-9442]
Properly handle nullable fields in Select
reuvenlax opened a new pull request #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046
Fix the selected schema to properly represent nullable nested fields.
Fix the schema code to check for null values and not throw NullPointerExceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] alexvanboxel commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595462750
> @alexvanboxel are you talking about the RabbitMQ failure?
yes (rookie, mistake of me)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] iemejia commented on a change in pull request #11046:
[BEAM-9442] Properly handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388257264
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##########
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+ public int reserveSlot() {
Review comment:
nit: (slightly related to this PR) can we make `SelectByteBuddyHelpers` package private please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] alexvanboxel commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-598399674
@iemejia wasn't available this week. His remark are fixed. So LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-598285299
friendly ping: @alexvanboxel @iemejia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on a change in pull request #11046:
[BEAM-9442] Properly handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on a change in pull request #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388399575
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##########
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+ public int reserveSlot() {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] alexvanboxel commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595455457
The error in the test is my fault, approved a fix without seeing the tests were ran. Just need to be rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595420264
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595320745
Run Spotless PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax merged pull request #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax merged pull request #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-596325819
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595383277
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-595459415
@alexvanboxel are you talking about the RabbitMQ failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-598472254
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on issue #11046: [BEAM-9442] Properly
handle nullable fields in Select
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#issuecomment-596817172
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services