You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org> on 2023/12/09 14:13:09 UTC
[PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Phuc-Hong-Tran opened a new pull request, #14979:
URL: https://github.com/apache/kafka/pull/14979
Change:
*Refactored `AbstractFetch` so only `Fetcher` will check for node status when creating fetch requests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1856814683
hm let's me try again, the ci failed to start it seems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1856802349
thanks. seems like all test aborted, let me reopen the pr to trigger the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee closed pull request #14979: KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
URL: https://github.com/apache/kafka/pull/14979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1856796442
@philipnee PTAL, the context for this one is here: https://github.com/apache/kafka/pull/14406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1856996345
@philipnee do you think I should close this one and open a new PR instead? the ci doesn't seem to restart after we close and re-open this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran closed pull request #14979: KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
URL: https://github.com/apache/kafka/pull/14979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran closed pull request #14979: KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
URL: https://github.com/apache/kafka/pull/14979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran closed pull request #14979: KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
URL: https://github.com/apache/kafka/pull/14979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]
Posted by "Phuc-Hong-Tran (via GitHub)" <gi...@apache.org>.
Phuc-Hong-Tran commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1848422315
@kirktrue, Can I have a review for this PR? Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org