You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "bernardodemarco (via GitHub)" <gi...@apache.org> on 2025/06/05 15:23:25 UTC
[PR] [KVM] CPU Features for System VMs [cloudstack]
bernardodemarco opened a new pull request, #10964:
URL: https://github.com/apache/cloudstack/pull/10964
### Description
Currently, when defining the CPU configuration of VMs with KVM, the Apache CloudStack Agent executes the following workflow:
https://github.com/apache/cloudstack/blob/41b4f0afd5321e987973b615b566365e48228c6e/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2980-L2993
As can be noticed, the CPU features are only considered for end-user VMs; they are completely ignored for system VMs. This can lead to system VMs deployment inconsistencies and errors. For instance, when it is required to disable CPU flags for a given CPU model, because the host CPU does not support such flags, an error similar to the following will be returned by Libvirt when trying to deploy system VMs:
```bash
Error while deploying VM. org.libvirt.LibvirtException: the CPU is incompatible with host CPU: Host CPU does not provide required features: hle, rtm, avx512-bf16, taa-no
```
Therefore, this PR proposes to add a new property, called `systemvm.guest.cpu.features`, to define CPU features for system VMs. This enhancement could be simply performed by removing the following `if` statement:
https://github.com/apache/cloudstack/blob/41b4f0afd5321e987973b615b566365e48228c6e/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2987-L2989
IMHO, it would be better from a UX perspective. However, it would break backwards compatibility and, thus, the proposal is to introduce the new `systemvm.guest.cpu.features` property.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
1. Defined the following properties in the `agent.properties` of the KVM hosts:
```bash
guest.cpu.mode=custom
guest.cpu.model=Cooperlake
guest.cpu.features=-hle -rtm -avx512-bf16 -taa-no
```
2. Restarted the Apache CloudStack Agent and verified that the deployment of system VMs failed with the following error:
```bash
2025-06-05 15:09:14,122 WARN [resource.wrapper.LibvirtStartCommandWrapper] (AgentRequest-Handler-2:[]) (logid:9fdcf003) LibvirtException org.libvirt.LibvirtException: the CPU is incompatible with host CPU: Host CPU does not provide required features: hle, rtm, avx512-bf16, taa-no
```
3. Added the `systemvm.guest.cpu.features` property:
```bash
guest.cpu.mode=custom
guest.cpu.model=Cooperlake
guest.cpu.features=-hle -rtm -avx512-bf16 -taa-no
systemvm.guest.cpu.features=-hle -rtm -avx512-bf16 -taa-no
```
4. Restarted the Apache CloudStack Agent and verified that the deployment of system VMs was successfully accomplished.
<details>
<summary><code>virsh dumpxml --domain v-8-VM</code></summary>
```xml
<domain type='kvm' id='6'>
<name>v-8-VM</name>
<uuid>5401be72-ff16-44b5-b43a-efb56004aac2</uuid>
<description>Debian GNU/Linux 12 (64-bit)</description>
<memory unit='KiB'>1048576</memory>
<currentMemory unit='KiB'>1048576</currentMemory>
<vcpu placement='static'>1</vcpu>
<cputune>
<shares>278</shares>
</cputune>
<resource>
<partition>/machine</partition>
</resource>
<sysinfo type='smbios'>
<system>
<entry name='manufacturer'>Apache Software Foundation</entry>
<entry name='product'>CloudStack KVM Hypervisor</entry>
<entry name='serial'>5401be72-ff16-44b5-b43a-efb56004aac2</entry>
<entry name='uuid'>5401be72-ff16-44b5-b43a-efb56004aac2</entry>
</system>
</sysinfo>
<os>
<type arch='x86_64' machine='pc-i440fx-8.2'>hvm</type>
<boot dev='cdrom'/>
<boot dev='hd'/>
<smbios mode='sysinfo'/>
</os>
<features>
<acpi/>
<apic/>
<pae/>
</features>
<cpu mode='custom' match='exact' check='full'>
<model fallback='forbid'>Cooperlake</model>
<topology sockets='1' dies='1' cores='1' threads='1'/>
<feature policy='disable' name='hle'/>
<feature policy='disable' name='rtm'/>
<feature policy='disable' name='avx512-bf16'/>
<feature policy='disable' name='taa-no'/>
<feature policy='require' name='hypervisor'/>
</cpu>
<clock offset='utc'>
<timer name='kvmclock'/>
</clock>
<on_poweroff>destroy</on_poweroff>
<on_reboot>restart</on_reboot>
<on_crash>destroy</on_crash>
<devices>
<emulator>/usr/bin/qemu-system-x86_64</emulator>
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<source file='/mnt/cb058c32-08a7-36ab-a540-8cee5f1a6b9f/f6d19465-c40b-4e23-bc0e-1dd07b1da7dc' index='2'/>
<backingStore type='file' index='3'>
<format type='qcow2'/>
<source file='/mnt/cb058c32-08a7-36ab-a540-8cee5f1a6b9f/b7933756-0b58-4270-9ce2-fcc13ab02b63'/>
<backingStore/>
</backingStore>
<target dev='vda' bus='virtio'/>
<serial>f6d19465c40b4e23bc0e</serial>
<alias name='virtio-disk0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu'/>
<target dev='hdc' bus='ide'/>
<readonly/>
<alias name='ide0-1-0'/>
<address type='drive' controller='0' bus='1' target='0' unit='0'/>
</disk>
<controller type='usb' index='0' model='piix3-uhci'>
<alias name='usb'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
</controller>
<controller type='pci' index='0' model='pci-root'>
<alias name='pci.0'/>
</controller>
<controller type='ide' index='0'>
<alias name='ide'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
</controller>
<controller type='virtio-serial' index='0'>
<alias name='virtio-serial0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
</controller>
<interface type='bridge'>
<mac address='0e:00:a9:fe:0f:9e'/>
<source bridge='cloud0'/>
<target dev='vnet7'/>
<model type='virtio'/>
<link state='up'/>
<alias name='net0'/>
<rom bar='off' file=''/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>
<interface type='bridge'>
<mac address='1e:00:b7:00:00:01'/>
<source bridge='cloudbr0'/>
<target dev='vnet8'/>
<model type='virtio'/>
<link state='up'/>
<alias name='net1'/>
<rom bar='off' file=''/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
</interface>
<interface type='bridge'>
<mac address='1e:00:40:00:00:0b'/>
<source bridge='cloudbr0'/>
<target dev='vnet9'/>
<model type='virtio'/>
<link state='up'/>
<alias name='net2'/>
<rom bar='off' file=''/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
</interface>
<serial type='pty'>
<source path='/dev/pts/2'/>
<target type='isa-serial' port='0'>
<model name='isa-serial'/>
</target>
<alias name='serial0'/>
</serial>
<console type='pty' tty='/dev/pts/2'>
<source path='/dev/pts/2'/>
<target type='serial' port='0'/>
<alias name='serial0'/>
</console>
<channel type='unix'>
<source mode='bind' path='/var/lib/libvirt/qemu/v-8-VM.org.qemu.guest_agent.0'/>
<target type='virtio' name='org.qemu.guest_agent.0' state='connected'/>
<alias name='channel0'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
<input type='tablet' bus='usb'>
<alias name='input0'/>
<address type='usb' bus='0' port='1'/>
</input>
<input type='mouse' bus='ps2'>
<alias name='input1'/>
</input>
<input type='keyboard' bus='ps2'>
<alias name='input2'/>
</input>
<graphics type='vnc' port='5901' autoport='yes' listen='192.168.100.230'>
<listen type='address' address='192.168.100.230'/>
</graphics>
<audio id='1' type='none'/>
<video>
<model type='cirrus' vram='16384' heads='1' primary='yes'/>
<alias name='video0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</video>
<watchdog model='i6300esb' action='none'>
<alias name='watchdog0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
</watchdog>
<memballoon model='virtio'>
<alias name='balloon0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/>
</memballoon>
</devices>
<seclabel type='dynamic' model='dac' relabel='yes'>
<label>+0:+0</label>
<imagelabel>+0:+0</imagelabel>
</seclabel>
</domain>
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2971453401
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3191255825
> Basically, Apache CloudStack allows operators to configure the CPU model that is exposed to VMs in KVM through three properties that can be defined in `agent.properties`: `guest.cpu.mode`, `guest.cpu.model` and `guest.cpu.features`.
>
> The `guest.cpu.mode` property accepts three possible values:
>
> * `custom`: Allows the customization of the CPU model, which should be defined in the `guest.cpu.model` setting. For instance:
> ```shell
> guest.cpu.mode=custom
> guest.cpu.model=Skylake-Server
> ```
>
>
>
>
>
>
>
>
>
>
>
> The available models for a given architecture can be listed through the following command:
> ```shell
> virsh cpu-models <architecture>
> ```
> * `host-model`: Libvirt identifies which model is more similar to the host's CPU model and adds extra features to approximate the host model as closely as possible.
> * `host-passthrough`: Libvirt will communicate to KVM the exact characteristics of the host's CPU. The main difference from the `host-model` mode is that instead of pairing CPU flags, all the CPU details from the host are paired.
>
> The `guest.cpu.features` setting can be used to add or remove individual CPU features, for instance:
>
> ```shell
> guest.cpu.mode=custom
> guest.cpu.model=Skylake-Server
> guest.cpu.features=aes mmx avx
> ```
>
> As can be noticed from the Agent logs that have been provided:
>
> ```shell
> 2025-08-13 10:35:56,850 WARN [resource.wrapper.LibvirtStartCommandWrapper] (AgentRequest-Handler-2:[]) (logid:bfd1c45f) LibvirtException org.libvirt.LibvirtException: XML error: Non-empty feature list specified without CPU model
> ```
>
> Libvirt complains about specifying a list of flags without a CPU model. Therefore, to apply CPU flags in KVM, it is required to meet one of the following requirements:
>
> * Define `guest.cpu.mode=host-model` and specify the flags;
> * Define `guest.cpu.mode=host-passthrough` and specify the flags; or,
> * Define `guest.cpu.mode=custom`, `guest.cpu.model=<cpu-model>` and specify the flags.
>
> Otherwise, Libvirt will complain that a CPU model has not been specified.
@bernardodemarco have you raised any doc PR with these details? if not, can you create one. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2973651862
<b>[SF] Trillian test result (tid-13522)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 90080 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10964-t13522-kvm-ol8.zip
Smoke tests completed. 102 look OK, 39 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_nic_secondaryip_add_remove | `Error` | 22.89 | test_multipleips_per_nic.py
test_network_acl | `Error` | 2.38 | test_network_acl.py
test_01_verify_ipv6_network | `Error` | 3.17 | test_network_ipv6.py
test_01_verify_ipv6_network | `Error` | 3.17 | test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.67 | test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.67 | test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 1.54 | test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.62 | test_network_permissions.py
test_delete_account | `Error` | 22.70 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 2.50 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 2.50 | test_network.py
test_deploy_vm_l2network | `Error` | 2.54 | test_network.py
test_deploy_vm_l2network | `Error` | 2.54 | test_network.py
test_l2network_restart | `Error` | 3.58 | test_network.py
test_l2network_restart | `Error` | 3.58 | test_network.py
ContextSuite context=TestL2Networks>:teardown | `Error` | 4.70 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 11.72 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 12.69 | test_network.py
test_reboot_router | `Error` | 7.47 | test_network.py
test_releaseIP | `Error` | 7.03 | test_network.py
test_releaseIP_using_IP | `Error` | 7.41 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 14.36 | test_network.py
test_01_deployVMInSharedNetwork | `Failure` | 1.34 | test_network.py
test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 1.11 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.10 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.24 | test_network.py
test_01_deployVMInSharedNetwork | `Failure` | 1.46 | test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 2.56 | test_network.py
test_01_nic | `Error` | 56.23 | test_nic.py
test_01_non_strict_host_anti_affinity | `Error` | 3.62 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 2.59 | test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_isolated_persistent_network | `Error` | 0.22 | test_persistent_network.py
test_02_L2_persistent_network | `Error` | 1.25 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 2.50 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Error` | 2.50 | test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 2.56 | test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 7.02 | test_portforwardingrules.py
test_01_add_primary_storage_disabled_host | `Error` | 0.28 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.23 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.40 | test_primary_storage.py
test_01_primary_storage_scope_change | `Error` | 0.11 | test_primary_storage_scope.py
test_01_vpc_privategw_acl | `Failure` | 7.84 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 7.49 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 8.99 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 7.79 | test_privategw_acl.py
test_09_project_suspend | `Error` | 2.56 | test_projects.py
test_10_project_activation | `Error` | 2.43 | test_projects.py
test_01_purge_expunged_api_vm_start_date | `Error` | 3.59 | test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date | `Error` | 3.12 | test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date | `Error` | 1.86 | test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date | `Error` | 2.03 | test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering | `Error` | 1.47 | test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task | `Error` | 356.88 | test_purge_expunged_vms.py
test_CRUD_operations_userdata | `Error` | 1523.11 | test_register_userdata.py
test_deploy_vm_with_registered_userdata | `Error` | 7.93 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 7.91 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 7.48 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 7.93 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 7.49 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 8.57 | test_register_userdata.py
test_user_userdata_crud | `Error` | 7.75 | test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestResourceNames>:setup | `Error` | 0.00 | test_resource_names.py
ContextSuite context=TestRestoreVM>:setup | `Error` | 0.00 | test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_migrate_vm_strict_tags_success | `Error` | 0.27 | test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure | `Error` | 0.27 | test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success | `Error` | 0.29 | test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure | `Error` | 0.29 | test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success | `Error` | 0.26 | test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure | `Error` | 0.28 | test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 0.27 | test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 2.73 | test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 0.27 | test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 5.91 | test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure | `Failure` | 0.30 | test_vm_strict_host_tags.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.32 | test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py
ContextSuite context=TestSharedFSLifecycle>:setup | `Error` | 0.00 | test_sharedfs_lifecycle.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
test_09_reboot_ssvm_forced | `Failure` | 0.04 | test_ssvm.py
test_10_reboot_cpvm_forced | `Failure` | 0.04 | test_ssvm.py
test_11_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py
test_12_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.69 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.70 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.68 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.69 | test_templates.py
test_01_register_template_direct_download_flag | `Error` | 0.07 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 0.00 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 0.06 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.21 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_scale_up_verify | `Failure` | 35.06 | test_vm_autoscaling.py
test_02_update_vmprofile_and_vmgroup | `Failure` | 245.82 | test_vm_autoscaling.py
test_03_scale_down_verify | `Failure` | 304.63 | test_vm_autoscaling.py
test_04_stop_remove_vm_in_vmgroup | `Failure` | 0.03 | test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network | `Failure` | 43.63 | test_vm_autoscaling.py
test_06_autoscaling_vmgroup_on_project_network | `Error` | 43.63 | test_vm_autoscaling.py
test_07_autoscaling_vmgroup_on_vpc_network | `Error` | 1.24 | test_vm_autoscaling.py
ContextSuite context=TestVmAutoScaling>:teardown | `Error` | 10.44 | test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host | `Error` | 0.10 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 1.44 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.35 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.14 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.38 | test_vm_deployment_planner.py
test_01_migrate_VM_and_root_volume | `Error` | 100.06 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 56.19 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 88.53 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 227.35 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 155.34 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 0.07 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3111840463
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3191352132
@sureshanaparti , this being a non-LTS release, should we merge anyway? (in spite of missing/while waiting on docs.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2944977264
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3079219576
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3038926553
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3037049907
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3077449343
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3131305760
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3191357741
> > @bernardodemarco have you raised any doc PR with these details? if not, can you create one. thanks.
>
> @sureshanaparti, sure, I'll try to open a doc PR ASAP
thanks @bernardodemarco
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3132840500
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3183636990
> > PR Status: Verification failed
>
> @rosi-shapeblue, thanks for your review!
>
> Could you further explain what verification failed?
@bernardodemarco - I was still updating my comment; could you please check it https://github.com/apache/cloudstack/pull/10964#pullrequestreview-3115402433 and let me know if any questions arise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3183633612
@bernardodemarco - I was still updating my comment; could you please check it https://github.com/apache/cloudstack/pull/10964#pullrequestreview-3115402433 and let me know if any questions arise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2963775362
> intiutively, I’d just apply the user VM settings to systemVMs as well.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2957371513
> What is the backwards incompatibilty you fear?
@DaanHoogland, the backwards incompatibility lies in the fact that the `guest.cpu.features` property is currently used to define CPU flags only for end-user VMs. If we change it to also apply to system VMs, operators would lose the ability to set flags exclusively for end-user VMs.
> @bernardodemarco , as per your description, would it not make sense to always apply guest.cpu.features to systemvms as well?
Yes, it would. I can update the PR tomorrow to reflect this. What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3038929267
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3037191306
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3040898972
<b>[SF] Trillian test result (tid-13693)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53659 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10964-t13693-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_isolate_network_password_server | `Failure` | 11.08 | test_password_server.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2971205297
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3112767095
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3183688837
@rosi-shapeblue, thanks very much for testing!
Basically, Apache CloudStack allows operators to configure the CPU model that is exposed to VMs in KVM through three properties that can be defined in `agent.properties`: `guest.cpu.mode`, `guest.cpu.model` and `guest.cpu.features`.
The `guest.cpu.mode` property accepts three possible values:
- `custom`: Allows the customization of the CPU model, which should be defined in the `guest.cpu.model` setting. For instance:
```bash
guest.cpu.mode=custom
guest.cpu.model=Skylake-Server
```
The available models for a given architecture can be listed through the following command:
```bash
virsh cpu-models <architecture>
```
- `host-model`: Libvirt identifies which model is more similar to the host's CPU model and adds extra features to approximate the host model as closely as possible.
- `host-passthrough`: Libvirt will communicate to KVM the exact characteristics of the host's CPU. The main difference from the `host-model` mode is that instead of pairing CPU flags, all the CPU details from the host are paired.
The `guest.cpu.features` setting can be used to add or remove individual CPU features, for instance:
```bash
guest.cpu.mode=custom
guest.cpu.model=Skylake-Server
guest.cpu.features=aes mmx avx
```
As can be noticed from the Agent logs that have been provided:
```bash
2025-08-13 10:35:56,850 WARN [resource.wrapper.LibvirtStartCommandWrapper] (AgentRequest-Handler-2:[]) (logid:bfd1c45f) LibvirtException org.libvirt.LibvirtException: XML error: Non-empty feature list specified without CPU model
```
Libvirt complains about specifying a list of flags without a CPU model. Therefore, to apply CPU flags in KVM, it is required to meet one of the following requirements:
- Define `guest.cpu.mode=host-model` and specify the flags;
- Define `guest.cpu.mode=host-passthrough` and specify the flags; or,
- Define `guest.cpu.mode=custom`, `guest.cpu.model=<cpu-model>` and specify the flags.
Otherwise, Libvirt will complain that a CPU model has not been specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2955834602
@bernardodemarco , as per your description, would it not make sense to always apply `guest.cpu.features` to systemvms as well? What is the backwards incompatibilty you fear? It feels to me like this is not user facing and shouldn’t be an issue, only a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3112338340
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3111842050
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2971202972
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2972495732
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2963698050
> > What is the backwards incompatibilty you fear?
>
> @DaanHoogland, the backwards incompatibility lies in the fact that the `guest.cpu.features` property is currently used to define CPU flags only for end-user VMs. If we change it to also apply to system VMs, operators would lose the ability to set flags exclusively for end-user VMs.
>
> > @bernardodemarco , as per your description, would it not make sense to always apply guest.cpu.features to systemvms as well?
>
> Yes, it would. I can update the PR tomorrow to reflect this. What are your thoughts?
I do not know what would be wisdom here.
- is a different set of settings needed for VMs and systemVMs?
- would you ever want to not apply settings to systemVMs?
intiutively, I’d just apply the user VM settings to systemVMs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2972497098
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3183478257
> PR Status: Verification failed
@rosi-shapeblue, thanks for your review!
Could you further explain what verification failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2945191025
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2944984754
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2945000532
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10964?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 3.96%. Comparing base [(`41b4f0a`)](https://app.codecov.io/gh/apache/cloudstack/commit/41b4f0afd5321e987973b615b566365e48228c6e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d44a947`)](https://app.codecov.io/gh/apache/cloudstack/commit/d44a9473b13cdf1abe863dfc62a8f49cd8f05e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (41b4f0a) and HEAD (d44a947). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (41b4f0a) | HEAD (d44a947) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #10964 +/- ##
=============================================
- Coverage 16.57% 3.96% -12.62%
=============================================
Files 5719 405 -5314
Lines 507200 32959 -474241
Branches 61574 5869 -55705
=============================================
- Hits 84093 1307 -82786
+ Misses 413688 31502 -382186
+ Partials 9419 150 -9269
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.96% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10964?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2975361539
> Could we rerun the tests?
Let’s first try the healtcheck PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2957978293
<b>[SF] Trillian test result (tid-13482)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 61395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10964-t13482-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 483.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3037052141
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2967353261
> > intiutively, I’d just apply the user VM settings to systemVMs as well.
>
> +1
Ok, nice. ASAP I'll change the PR to address that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2955823188
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3132195888
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3112020424
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3079572050
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3079227504
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2973836954
@DaanHoogland, thanks for running the integration tests!
I've taken a quick look at the errors and the Management Server logs. It seems that they are related to environment issues:
```
2025-06-15 01:57:28,101 DEBUG [c.c.d.FirstFitPlanner] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) Searching all possible resources under this Zone: Zone {"id": "1", "name": "pr10964-t13522-kvm-ol8", "uuid": "cffaeffc-2a1d-4a2a-8ed6-27b88c41bbaf"}
2025-06-15 01:57:28,102 DEBUG [c.c.d.FirstFitPlanner] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) Listing clusters in order of aggregate capacity, that have (at least one host with) enough CPU and RAM capacity under this Zone: 1
2025-06-15 01:57:28,106 DEBUG [c.c.d.FirstFitPlanner] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) Removing from the clusterId list these clusters from avoid set: [1]
2025-06-15 01:57:28,107 DEBUG [c.c.d.FirstFitPlanner] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) No clusters found after removing disabled clusters and clusters in avoid list, returning.
2025-06-15 01:57:28,131 DEBUG [c.c.c.CapacityManagerImpl] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) VM instance {"id":242,"instanceName":"i-283-242-VM","state":"Stopped","type":"User","uuid":"8c2148d3-1e96-4d2a-b78d-633911a13e98"} state transited from [Starting] to [Stopped] with event [OperationFailed]. VM's original host: null, new host: null, host before state transition: null
2025-06-15 01:57:28,158 ERROR [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) Invocation exception, caused by: com.cloud.exception.InsufficientServerCapacityException: Unable to create a deployment for VM instance {"id":242,"instanceName":"i-283-242-VM","state":"Starting","type":"User","uuid":"8c2148d3-1e96-4d2a-b78d-633911a13e98"}Scope=interface com.cloud.dc.DataCenter; id=1
2025-06-15 01:57:28,158 INFO [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668, ctx-ba951d3c]) (logid:b7fc88c8) Rethrow exception com.cloud.exception.InsufficientServerCapacityException: Unable to create a deployment for VM instance {"id":242,"instanceName":"i-283-242-VM","state":"Starting","type":"User","uuid":"8c2148d3-1e96-4d2a-b78d-633911a13e98"}Scope=interface com.cloud.dc.DataCenter; id=1
2025-06-15 01:57:28,158 DEBUG [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668]) (logid:b7fc88c8) Done with run of VM work job: com.cloud.vm.VmWorkStart for VM 242, job origin: 2667
2025-06-15 01:57:28,158 ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-7:[ctx-e8c695d7, job-2667/job-2668]) (logid:b7fc88c8) Unable to complete AsyncJob {"accountId":2,"cmd":"com.cloud.vm.VmWorkStart","cmdInfo":"rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAAAAAAAAAACAAAAAAAAAAIAAAAAAAAA8nQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAAHBwcHBwcHBwcHA","cmdVersion":0,"completeMsid":null,"created":"Sun Jun 15 01:57:27 UTC 2025","id":2668,"initMsid":32989224371150,"instanceId":null,"instanceType":null,"lastPolle
d":null,"lastUpdated":null,"processStatus":0,"removed":null,"result":null,"resultCode":0,"status":"IN_PROGRESS","userId":2,"uuid":"90bb3d64-5c02-4776-9903-a603297a576d"}, job origin: 2667 com.cloud.exception.InsufficientServerCapacityException: Unable to create a deployment for VM instance {"id":242,"instanceName":"i-283-242-VM","state":"Starting","type":"User","uuid":"8c2148d3-1e96-4d2a-b78d-633911a13e98"}Scope=interface com.cloud.dc.DataCenter; id=1
at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1275)
at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5582)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:102)
at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5706)
at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:99)
at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:689)
at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:637)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
```
Could we rerun the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3112340111
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3132198194
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2955821726
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-2971202505
> Ok, nice. ASAP I'll change the PR to address that
@DaanHoogland, @weizhouapache, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964#issuecomment-3191329890
@rosi-shapeblue, thanks for testing this one!
> @bernardodemarco have you raised any doc PR with these details? if not, can you create one. thanks.
@sureshanaparti, sure, I'll try to open a doc PR ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] CPU Features for System VMs [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti merged PR #10964:
URL: https://github.com/apache/cloudstack/pull/10964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org