[GitHub] ivankelly opened a new pull request #1857: changingEnsemble should be negated before calling unset success

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #1857: changingEnsemble should be negated before calling unset success
URL: https://github.com/apache/bookkeeper/pull/1857
 
 
   If the first pending add op is completed, but does not have the
   replaced bookie in its write set, callbacks are triggered straight
   away.
   
   Previously this would then hang forever, as the changingEnsemble would
   be true. This patch sets changingEnsemble to false before calling
   unsetSuccessAndSendWriteRequest so that if callbacks are triggered
   straight away, they can actually complete. It also moves the call to
   unsetSuccessAndSendWriteRequest outside of the metadataLock so that
   the callbacks don't run inside the lock.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services