[GitHub] [druid] rohangarg commented on pull request #12948: Fixing json creator for s3 storage connector provider

[GitBox <gi...@apache.org>]

rohangarg commented on PR #12948:
URL: https://github.com/apache/druid/pull/12948#issuecomment-1225768999

   A doubt I had was that is it possible to do the `StorageConnector` injection via `PolyBind` instead of `JsonConfigurator`? `PolyBind` provides support to add multiple implementations of an interface via a `MapBinder` and also provides to choose between them using a user property via `createChoice` method.
   If that's possible, then the `StorageConnector` interface could be implemented as a simple guice injectable object in the extensions. The `StorageConnectorProvider` then would be replaced by `ConffigedProvider` which is an implementation detail of `PolyBind`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org