You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/23 07:51:00 UTC

[jira] [Commented] (SCB-517) service center starter for spring boot/cloud improvement

    [ https://issues.apache.org/jira/browse/SCB-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447685#comment-16447685 ] 

ASF GitHub Bot commented on SCB-517:
------------------------------------

liubao68 opened a new pull request #672: [SCB-517]simplify using spring-boot-starter-registry
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/672
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> service center starter for spring boot/cloud improvement
> --------------------------------------------------------
>
>                 Key: SCB-517
>                 URL: https://issues.apache.org/jira/browse/SCB-517
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>            Reporter: liubao
>            Assignee: liubao
>            Priority: Major
>
> Now, when enabled spring-boot-starter-discovery, we should add 
> @EnableAutoConfiguration
> @ImportResource(locations = "classpath*:META-INF/spring/*.bean.xml")
> to user class. But we can simplify it to write no code. On the other hand, if user use this two code, it will work fine. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)