You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/12/22 19:24:55 UTC

[I] Split equivalence code into smaller modules [arrow-datafusion]

alamb opened a new issue, #8633:
URL: https://github.com/apache/arrow-datafusion/issues/8633

   ### Is your feature request related to a problem or challenge?
   
   As equivalence and ordering become ever more important, I would like to break the code up into smaller modules to make it harder to handle.
   
   At almost 3000 lines with several large classes that are overlapping. the existing equivalence.rs is hard to understand.
   
   I would like to break it up into smaller modules.
   
   In fact I didn't even realize there were so many equivalence tracking structures until I started looking at the code more closely.
   
   
   
   ### Describe the solution you'd like
   
   Move `EquivalenceClass`, `EquivalenceGroup`, `OrderingEquivalenceClass`, `ProjectionMapping`, `EquivalenceProperties`; and into their own modules, updating any internal apis if necessary
   
   
   
   I made a PR (that has gone stale) that did this: https://github.com/apache/arrow-datafusion/pull/8235
   
   
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   I think this is a relatively good first issue as there is a PR that shows how to do it and it is mostly a software engineering exercise in moving code around rather than requiring deep DataFusion knowledge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Split equivalence code into smaller modules [arrow-datafusion]

Posted by "tushushu (via GitHub)" <gi...@apache.org>.
tushushu commented on issue #8633:
URL: https://github.com/apache/arrow-datafusion/issues/8633#issuecomment-1868186795

   @alamb  Hey Andrew, may I take this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Split equivalence code into smaller modules [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8633:
URL: https://github.com/apache/arrow-datafusion/issues/8633#issuecomment-1868009846

   FYI @mustafasrepo and @ozankabak  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Split equivalence code into smaller modules [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #8633: Split equivalence code into smaller modules
URL: https://github.com/apache/arrow-datafusion/issues/8633


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org