[GitHub] [solr] stillalex commented on a diff in pull request #1447: SOLR-16694: Shortcut Http2SolrClient mimeType check for default response parse

["stillalex (via GitHub)" <gi...@apache.org>]

stillalex commented on code in PR #1447:
URL: https://github.com/apache/solr/pull/1447#discussion_r1134617599


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -136,6 +136,11 @@ public class Http2SolrClient extends SolrClient {
   private long requestTimeoutMillis;
 
   protected ResponseParser parser = new BinaryResponseParser();
+  private final Set<String> defaultMimeTypes =

Review Comment:
   wouldn't it be better if this happens after the parser is initialized from the builder? https://github.com/apache/solr/blob/237ff32720ac02c9d950e1aa863d0c957a0c6702/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L191 could cover the case there a different parser is passed in, in case that is useful.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org