You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/07 08:54:16 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
XD-DENG opened a new pull request #12149:
URL: https://github.com/apache/airflow/pull/12149
closes: https://github.com/apache/airflow/issues/12148 , a bug I observe in 2.0.0a2.
The root-cause is simple:
if the connection data is `{..., "extra": None}` (which is common), then `form.data.get('extra', '{}')` would return `None` rather than `'{}'`, which causes error given `json.loads()` does not accept `None`.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
related: https://github.com/apache/airflow/issues/12148
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12149:
URL: https://github.com/apache/airflow/pull/12149#issuecomment-723497636
It's the quarantined tests suite failing, and the main test cases are fine. So merging this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12149:
URL: https://github.com/apache/airflow/pull/12149#issuecomment-723479981
hi @potiuk @ashb @kaxil , simple test is added to ensure case where connection's `extra` is `None` can be handled.
Earlier I had another test case where connection has no `extra` field. But eventually I decided to remove it given this case may never happen if I'm not wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12149:
URL: https://github.com/apache/airflow/pull/12149#issuecomment-723421172
Thanks @potiuk and @ashb .
Have some arrangement later so will only be able to add the test either tonight or tomorrow. Will ping you then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12149:
URL: https://github.com/apache/airflow/pull/12149#issuecomment-723426497
[The Workflow run](https://github.com/apache/airflow/actions/runs/350942373) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12149:
URL: https://github.com/apache/airflow/pull/12149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12149: Allow Connection Edit View to handle entries with NULL 'extra'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12149:
URL: https://github.com/apache/airflow/pull/12149#issuecomment-723420791
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org