You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "dexterduck (via GitHub)" <gi...@apache.org> on 2023/05/23 20:18:24 UTC

[GitHub] [arrow-rs] dexterduck commented on pull request #4267: Parquet Reader/writer for fixed-size list arrays

dexterduck commented on PR #4267:
URL: https://github.com/apache/arrow-rs/pull/4267#issuecomment-1560068269

   @tustvold thanks for the feedback! 
   
   I implemented most of your corrections, and I added the two tests you suggested.
   I also updated the test that writes a list of structs so that the structs contain 2 fields instead of 1, to try to catch any potential errors in the def/rep level encoding.
   
   Following those changes, I believe the rep/def level writer logic is correct as-is, but it's possible I'm missing something. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org