You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Joe Orton <jo...@redhat.com> on 2008/05/23 21:36:57 UTC
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
On Fri, May 23, 2008 at 04:32:27PM -0000, William Rowe wrote:
> Author: wrowe
> Date: Fri May 23 09:32:27 2008
> New Revision: 659586
>
> URL: http://svn.apache.org/viewvc?rev=659586&view=rev
> Log:
> Abstract "--disable-dbd-dso" into "--disable-util-dso"; since the
> prior --enable-dbd-dso is now default, this is a noop for existing
> ./config.nice settings, and --disable-dbd-dso was previously the
> default and therefore unexpected.
No, -1, these need to be kept separate.
Enabling the LDAP DSO code by default is unequivocably a source
backwards compat break, it must be off by default. Existing httpd
releases will not build as-is against new APR 1.x releases like this.
joe
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Joe Orton wrote:
> On Fri, May 23, 2008 at 03:42:11PM -0500, William Rowe wrote:
>> Joe, does the attached patch float your boat?
>>
>> [hint to readers, apu-1-config --avoid-ldap --link-libtool --libs ]
>
> --ldap-libs is then redundant and should be dropped, and use of flags
> "--libs --avoid-ldap" should ideally do the same thing as the flags
> "--avoid-ldap --libs" but yes it looks like that would resolve my veto -
> thanks.
No - it's not, if you wish to combine it with --libs (we do, in the case
of httpd-2.something). So it's still useful to have both an everything
but ldap and a seperate ldap linkage spec.
Your welcome - hope you enjoyed your vacation :)
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Joe Orton wrote:
> On Fri, May 23, 2008 at 03:42:11PM -0500, William Rowe wrote:
>>
>> [hint to readers, apu-1-config --avoid-ldap --link-libtool --libs ]
>
> use of flags "--libs --avoid-ldap" should ideally do the same thing as
> the flags "--avoid-ldap --libs"
FWIW - all of the args to apu-1-config are order sensitive, so it doesn't
seem counter-intuitive to leave this as is.
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by Joe Orton <jo...@redhat.com>.
On Fri, May 23, 2008 at 03:42:11PM -0500, William Rowe wrote:
> Joe, does the attached patch float your boat?
>
> [hint to readers, apu-1-config --avoid-ldap --link-libtool --libs ]
--ldap-libs is then redundant and should be dropped, and use of flags
"--libs --avoid-ldap" should ideally do the same thing as the flags
"--avoid-ldap --libs" but yes it looks like that would resolve my veto -
thanks.
joe
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Joe, does the attached patch float your boat?
[hint to readers, apu-1-config --avoid-ldap --link-libtool --libs ]
William A. Rowe, Jr. wrote:
>
> Please focus on the apu-1-config script which is the only place things
> have changed behavior. And we can discuss how it should behave. But
> your veto has nothing to do with your justification for vetoing this
> patch, so if you still have a veto to this patch, please restate it.
Bill
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by Joe Orton <jo...@redhat.com>.
On Fri, May 23, 2008 at 03:08:10PM -0500, William Rowe wrote:
> It does not break backwards compat.
Existing releases of httpd will not build against APR-util like this;
configure with the LDAP modules as static and you'll see the link
failure.
So it is a source backwards compat break. Read the definition of source
compatibility at http://apr.apache.org/versioning.html#source
""
We define "source compatible" to mean that an application will continue
to build without error, and that the semantics will remain unchanged.
""
w.r.t. waiting a week - I've been on holiday. If nobody else cares to
review your patches, that's just tough luck.
joe
Re: svn commit: r659586 - in /apr/apr-util/branches/1.3.x: CHANGES
build/dbd.m4 build/dso.m4 configure.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Joe Orton wrote:
> On Fri, May 23, 2008 at 04:32:27PM -0000, William Rowe wrote:
>> Author: wrowe
>> Date: Fri May 23 09:32:27 2008
>> New Revision: 659586
>>
>> URL: http://svn.apache.org/viewvc?rev=659586&view=rev
>> Log:
>> Abstract "--disable-dbd-dso" into "--disable-util-dso"; since the
>> prior --enable-dbd-dso is now default, this is a noop for existing
>> ./config.nice settings, and --disable-dbd-dso was previously the
>> default and therefore unexpected.
>
> No, -1, these need to be kept separate.
>
> Enabling the LDAP DSO code by default is unequivocably a source
> backwards compat break, it must be off by default. Existing httpd
> releases will not build as-is against new APR 1.x releases like this.
No - either the platform can, will support dso architecture or it won't.
The dbm, iconv and xml are all obvious targets to pile-on to this.
It does not break backwards compat. Binary compat of apr[ru]_* -is-
identical. The only compat issue is the one that is pending a [vote].
This patch has nothing to do with the inclusion or exclusion of -lldap,
and it should be preserved as is.
Please focus on the apu-1-config script which is the only place things
have changed behavior. And we can discuss how it should behave. But
your veto has nothing to do with your justification for vetoing this
patch, so if you still have a veto to this patch, please restate it.
Bill