[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7334: GEODE-9990: turn DiskAccessException into CacheClosedException

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7334:
URL: https://github.com/apache/geode/pull/7334#discussion_r800895914



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java
##########
@@ -1310,7 +1311,16 @@ private void writeIFRecord(ByteBuffer bb) throws IOException {
   private void writeIFRecord(ByteBuffer bb, boolean doStats) throws IOException {
     assert lock.isHeldByCurrentThread();
     if (closed) {
-      throw new DiskAccessException("The disk store is closed", parent);
+      parent.getCache().getCancelCriterion().checkCancelInProgress();

Review comment:
       Could you extract this whole "if" block into a method "checkClosed"? We currently would call checkClosed from two places so this would get rid of some code duplication

##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
##########
@@ -3217,14 +3217,16 @@ public void forceIFCompaction() {
     @Override
     public String cancelInProgress() {
       if (isClosed()) {
-        return "The disk store is closed.";
+        return "The disk store is closed";
       } else {
         return null;
       }
     }
 
     @Override
     public RuntimeException generateCancelledException(Throwable e) {
+      logger.info("DiskStoreImpl.isClosed(): " + isClosed() + " isClosing(): " + isClosing());

Review comment:
       this looks like it might be debug logging that should be removed. It does not look like a log message that would be helpful to customers




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org