You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/10 12:47:28 UTC
[GitHub] [beam] sunjincheng121 commented on a change in pull request #10945:
[BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible
with Flink 1.10
sunjincheng121 commented on a change in pull request #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
URL: https://github.com/apache/beam/pull/10945#discussion_r390287605
##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -77,6 +67,7 @@ static ExecutionEnvironment createBatchExecutionEnvironment(
// depending on the master, create the right environment.
if ("[local]".equals(flinkMasterHostPort)) {
+ flinkConfiguration.setString("taskmanager.memory.managed.size", "2048m");
Review comment:
It will set the `taskmanager.memory.managed.size` as [128MB](https://github.com/apache/flink/blob/b90d1a269661f4e5ca132213a03169fc9011aaee/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java#L139) for MiniCluster if it's not set. I think set `taskmanager.memory.managed.fraction"` doesn't take effect here. Thoughts? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services