You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/21 16:53:00 UTC
[jira] [Work logged] (BEAM-13232) Underlying AWS Kinesis clients are not closed
[ https://issues.apache.org/jira/browse/BEAM-13232?focusedWorklogId=745248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745248 ]
ASF GitHub Bot logged work on BEAM-13232:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 16:52
Start Date: 21/Mar/22 16:52
Worklog Time Spent: 10m
Work Description: mosche opened a new pull request #17140:
URL: https://github.com/apache/beam/pull/17140
Close AWS clients properly in KinesisSource.
Additionally using lazy init for AWS clients to avoid unnecessary allocations for some use cases, e.g. for splitting (doesn't require cloudwatch).
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 745248)
Remaining Estimate: 0h
Time Spent: 10m
> Underlying AWS Kinesis clients are not closed
> ---------------------------------------------
>
> Key: BEAM-13232
> URL: https://issues.apache.org/jira/browse/BEAM-13232
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P3
> Labels: aws, aws-sdk-v2, kinesis
> Time Spent: 10m
> Remaining Estimate: 0h
>
> All across _KinesisSource_ and related Kinesis clients are neither shared nor closed. AWS clients are fairly resource heavy (thread/connection pool), so this should be fixed in the following places:
> * SimplifiedKinesisClient
> * KinesisSource.split
--
This message was sent by Atlassian Jira
(v8.20.1#820001)