[GitHub] [ozone] sodonnel commented on a diff in pull request #4758: HDDS-8674. Allow more EC pipelines based on number of volumes

["sodonnel (via GitHub)" <gi...@apache.org>]

sodonnel commented on code in PR #4758:
URL: https://github.com/apache/ozone/pull/4758#discussion_r1202532912


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableECContainerProvider.java:
##########
@@ -159,6 +160,16 @@ public ContainerInfo getContainer(final long size,
     }
   }
 
+  private int getMinimumPipelines(ECReplicationConfig repConfig) {

Review Comment:
   At this code path with be hit for every single block request, I wonder if we should perform this calculation every time? It has to iterate over all nodes in the cluster checking their state and then summing up their disk count. Its probably not needed to recalculate this every single time - we could either calculate it 1 in X times, or have some sort of time based recalculation. Its also called under a synchronized block, so it could become a point of contention in the block allocation flow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org