You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2025/08/25 22:32:54 UTC
[PR] fix: the typo in WorkflowAggregatedState [texera]
aglinxinyuan opened a new pull request, #3697:
URL: https://github.com/apache/texera/pull/3697
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #3697:
URL: https://github.com/apache/texera/pull/3697#issuecomment-3222192107
> Is there a setting we can use to require us to get rid of all warnings before we do the merge? Typically warnings are potential sources of bugs, and should be checked very carefully.
We could make warnings to be reported as error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3697:
URL: https://github.com/apache/texera/pull/3697#issuecomment-3222147760
> The change looks good. I am surprised the compiler didn't complain about this bug.
The compiler issued a warning instead of an error because it couldn't determine with certainty whether it was an actual error. That's how I found this typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #3697:
URL: https://github.com/apache/texera/pull/3697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3697:
URL: https://github.com/apache/texera/pull/3697#issuecomment-3222241027
We also have too many messages printed, making it difficult to distinguish warnings from other messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #3697:
URL: https://github.com/apache/texera/pull/3697#issuecomment-3222189308
Is there a setting we can use to require us to get rid of all warnings before we do the merge? Typically warnings are potential sources of bugs, and should be checked very carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: typo in WorkflowAggregatedState [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #3697:
URL: https://github.com/apache/texera/pull/3697#issuecomment-3222194668
I support this idea, which is a good practice for many systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org