[GitHub] [ozone] ChenSammi commented on a diff in pull request #4523: HDDS-8050. REST Endpoint for S3 secret manipulation

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on code in PR #4523:
URL: https://github.com/apache/ozone/pull/4523#discussion_r1294282131


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretConfigKeys.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.s3secret;
+
+/**
+ * This class contains constants for configuration keys used
+ * in S3 secret endpoint.
+ */
+public final class S3SecretConfigKeys {
+  public static final String OZONE_S3G_SECRET_HTTP_ENABLED_KEY =
+      "ozone.s3g.secret.http.enabled";
+  public static final String OZONE_S3G_SECRET_HTTP_AUTH_CONFIG_PREFIX =
+      "ozone.s3g.secret.http.auth.";
+  public static final String OZONE_S3G_SECRET_HTTP_AUTH_TYPE =
+      OZONE_S3G_SECRET_HTTP_AUTH_CONFIG_PREFIX + "type";
+  public static final String OZONE_S3G_SECRET_KEYTAB_FILE =
+      OZONE_S3G_SECRET_HTTP_AUTH_CONFIG_PREFIX + "kerberos.keytab";
+  public static final String
+      OZONE_S3G_SECRET_WEB_AUTHENTICATION_KERBEROS_PRINCIPAL =

Review Comment:
   OZONE_S3G_SECRET_WEB_AUTHENTICATION_KERBEROS_PRINCIPAL -> 
   
   OZONE_S3G_SECRET_HTTP_KERBEROS_PRINCIPAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org