You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/05 08:25:57 UTC
[GitHub] [skywalking-python] alonelaval opened a new pull request #33: add Component Id
alonelaval opened a new pull request #33:
URL: https://github.com/apache/skywalking-python/pull/33
add Component Id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] alonelaval commented on a change in pull request #33: add Component Id
Posted by GitBox <gi...@apache.org>.
alonelaval commented on a change in pull request #33:
URL: https://github.com/apache/skywalking-python/pull/33#discussion_r449859147
##########
File path: .gitignore
##########
@@ -7,4 +7,5 @@ __pycache__
build/
dist/
skywalking_python.egg-info/
-*.pyc
\ No newline at end of file
+*.pyc
+/apache_skywalking.egg-info/
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #33: Add component ID for requests plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #33:
URL: https://github.com/apache/skywalking-python/pull/33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #33: add Component Id
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #33:
URL: https://github.com/apache/skywalking-python/pull/33#discussion_r449850484
##########
File path: .gitignore
##########
@@ -7,4 +7,5 @@ __pycache__
build/
dist/
skywalking_python.egg-info/
-*.pyc
\ No newline at end of file
+*.pyc
+/apache_skywalking.egg-info/
Review comment:
Please remove the `skywalking_python.egg-info` (at line 9), I've forgot to rename it after I rename the module name, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org