[GitHub] [kafka] jolshan edited a comment on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

[GitBox <gi...@apache.org>]

jolshan edited a comment on pull request #11104:
URL: https://github.com/apache/kafka/pull/11104#issuecomment-905656665


   Looks like it was a really subtle bug. Consider the case where we have a partition in the session without a topic ID. We then add a new partition from that topic with an ID, but remove the partition that didn't have an ID.
   
   Here, we want to use IDs. When the receiving broker sees the topic IDs and currently has a session without them open, it will close that session so we can switch over to fully using topic IDs. Otherwise, we may get stuck not using topic IDs a little longer than we want to.
   
   I've added a check to see if the topic ID can be found in the current builder. Let me know if this makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org