[GitHub] [ant] maartenc commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST

[GitBox <gi...@apache.org>]

maartenc commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-667850214


   Thanks for the feedback @bodewig ,
   
   I don't think a `mappedresources` would help here, because the index-logic inside the `jar` task will transform the name of the jar to the basename of the jar or the name in the ClassPath manifest entry. 
   
   In my use-case, I don't have a ClassPath entry, but I don't want the jar basename in the index.list, I need another name mapping scheme which is based on the final location of the jars in our application, not a flat mapping because not all jars are located in the same directory. I thought using a filenamemapper for this would be an elegant solution.
   
   One thing I'm not sure of is the removal of the replacement of `addConfiguredIndexJars(Path p)` with `addConfiguredIndexJars(ResourceCollection rc)`. I think I can't keep the method with the Path argument, because otherwise that method might be chosen to configure the task (and I need the new addConfiguredIndexJars method). So I replaced it with the ResourceCollection variant for backwards compatibility, but I'm not sure this is good enough to match the Ant guidelines because client libraries that are using that method directly will need to be recompiled (existing build scripts will keep working I think).
   
   Maarten


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org