ChangeProcessor potentially warns only once for queue being full during its lifetime (without CommitRateLimiter)

[Vikas Saurabh <vi...@gmail.com>]

Hi,

_Disclaimer_ : I get confused with change processor code, so not sure
if this is an issue or PEBKAC

ChangeProcessor#queueSizeChanged sets blocking flag to true if queue
size is hit (or beyond). The warning "Revision queue is full. Further
revisions will be compacted." is logged only when it *wasn't*
blocking.

BUT, when queue empties, blocking flag is reset inside if block for
commitRateLimiter!=null. That, to me seems like
qFull->log->qEmpties->qFull won't log another warn. This sounds wrong
to me.

Thanks,
Vikas

Re: ChangeProcessor potentially warns only once for queue being full during its lifetime (without CommitRateLimiter)

[Vikas Saurabh <vi...@gmail.com>]

On Fri, Feb 10, 2017 at 4:55 PM, Stefan Egli <st...@apache.org> wrote:
> +1, looks like a bug to me.
>
Ok. Logged OAK-5626. I've some doubt if it's a good idea to simply
always reset. Would discuss it on the issue

Thanks,
Vikas

Re: ChangeProcessor potentially warns only once for queue being full during its lifetime (without CommitRateLimiter)

[Stefan Egli <st...@apache.org>]

+1, looks like a bug to me.

Cheers,
Stefan

On 09/02/17 23:17, "Vikas Saurabh" <vi...@gmail.com> wrote:

>Hi,
>
>_Disclaimer_ : I get confused with change processor code, so not sure
>if this is an issue or PEBKAC
>
>ChangeProcessor#queueSizeChanged sets blocking flag to true if queue
>size is hit (or beyond). The warning "Revision queue is full. Further
>revisions will be compacted." is logged only when it *wasn't*
>blocking.
>
>BUT, when queue empties, blocking flag is reset inside if block for
>commitRateLimiter!=null. That, to me seems like
>qFull->log->qEmpties->qFull won't log another warn. This sounds wrong
>to me.
>
>Thanks,
>Vikas