You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/31 19:47:00 UTC

[jira] [Commented] (DRILL-6650) Remove Stray Semicolon in Printing Results Listener

    [ https://issues.apache.org/jira/browse/DRILL-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564277#comment-16564277 ] 

ASF GitHub Bot commented on DRILL-6650:
---------------------------------------

ilooner opened a new pull request #1410: DRILL-6650: Remove stray semicolon in imports for PrintingResultsListener.
URL: https://github.com/apache/drill/pull/1410
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove Stray Semicolon in Printing Results Listener
> ---------------------------------------------------
>
>                 Key: DRILL-6650
>                 URL: https://issues.apache.org/jira/browse/DRILL-6650
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>
> Having empty import statements with stray semicolons can cause compilation in eclipse to fail. I investigated adding a checkstyle check to prevent empty import declarations, but apparently there is no way to do this. In fact having multiple semicolons in an import statement is technically not supported by the java spec https://stackoverflow.com/questions/8125558/eclipse-double-semi-colon-on-an-import. There is also a bug filed for the jdk for not throwing an error in this case
> https://bugs.openjdk.java.net/browse/JDK-8072390
> Since there is no way to automate checking this I am just going to manually remove this error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)