You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "davidhcoe (via GitHub)" <gi...@apache.org> on 2023/05/16 19:47:43 UTC

[GitHub] [arrow] davidhcoe commented on a diff in pull request #35496: GH-33856: [C#] Implement C Data Interface for C#

davidhcoe commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1195625799


##########
csharp/test/Apache.Arrow.Tests/TestData.cs:
##########
@@ -48,7 +50,7 @@ public static RecordBatch CreateSampleRecordBatch(int length, int columnSetCount
                 builder.Field(CreateField(Date32Type.Default, i));
                 builder.Field(CreateField(Date64Type.Default, i));
                 builder.Field(CreateField(Time32Type.Default, i));
-                builder.Field(CreateField(Time64Type.Default, i));

Review Comment:
   it looks like Tim32 can be seconds or milliseconds where as Time64 should be microseconds or nanoseconds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org