You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/13 07:34:29 UTC
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4467: vpc: fix ips on wrong interfaces after rebooting vpc vrs
weizhouapache commented on a change in pull request #4467:
URL: https://github.com/apache/cloudstack/pull/4467#discussion_r522733032
##########
File path: server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
##########
@@ -834,4 +837,11 @@ public boolean postStateTransitionEvent(final StateMachine2.Transition<State, Vi
// once from VpcVirtualNetworkApplianceManagerImpl and once from VirtualNetworkApplianceManagerImpl itself
return true;
}
+
+ private Nic getNicWithUpdatedDeviceId(final long nicId, int deviceId) {
+ NicVO nic = _nicDao.findById(nicId);
+ nic.setDeviceId(deviceId);
+ _nicDao.update(nic.getId(), nic);
+ return nic;
+ }
Review comment:
@sureshanaparti `updateNicWithDeviceId()` looks good to me. @DaanHoogland what's your opinion ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org