You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2022/06/12 11:30:11 UTC

[pulsar] branch master updated: [cleanup] [broker] delete deprecated comment in ManagedLedgerImpl (#15641)

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 421c2f861c8 [cleanup] [broker] delete deprecated comment in ManagedLedgerImpl (#15641)
421c2f861c8 is described below

commit 421c2f861c80dab218b2d17247fe02de7fa4552c
Author: fengyubiao <yu...@streamnative.io>
AuthorDate: Sun Jun 12 19:30:05 2022 +0800

    [cleanup] [broker] delete deprecated comment in ManagedLedgerImpl (#15641)
---
 .../java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java  | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index f3bcb611ca3..13c7b6a8db3 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -2615,12 +2615,6 @@ public class ManagedLedgerImpl implements ManagedLedger, CreateCallback {
 
     /**
      * Non-durable cursors have to be moved forward when data is trimmed since they are not retain that data.
-     * This method also addresses a corner case for durable cursors in which the cursor is caught up, i.e. the mark
-     * delete position happens to be the last entry in a ledger.  If the ledger is deleted, then subsequent
-     * calculations for backlog
-     * size may not be accurate since the method getNumberOfEntries we use in backlog calculation will not be able to
-     * fetch the ledger info of a deleted ledger. Thus, we need to update the mark delete position to the "-1" entry
-     * of the first ledger that is not marked for deletion.
      * This is to make sure that the `consumedEntries` counter is correctly updated with the number of skipped
      * entries and the stats are reported correctly.
      */