You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Brian Murray (JIRA)" <tu...@ws.apache.org> on 2007/05/02 19:46:16 UTC
[jira] Created: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Provide CTS Updates for HelperContext and a new DO creation mechanism
---------------------------------------------------------------------
Key: TUSCANY-1241
URL: https://issues.apache.org/jira/browse/TUSCANY-1241
Project: Tuscany
Issue Type: Test
Components: Java SDO Implementation
Reporter: Brian Murray
Priority: Minor
My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493391 ]
Kelvin Goodson commented on TUSCANY-1241:
-----------------------------------------
Hi Brian,
So far I have applied all but a handful of the updates that you have attached to my workspace. There I some things I still need to go back and look at but I was hoping to run the updates that I do have to compare the test runs with that of the current base.
However, for the updates which I have made, I get a number of compiler failures. Some just require a dependency on javax.xml.stream, which I guess requires an update dependency update in the pom/classpath, I'll look into that.
One that requires more effort to fix is the import of tuscany classes into the generic project. ParamatizedTestUtil imports import org.apache.tuscany.sdo.helper.XMLStreamHelper; and import org.apache.tuscany.sdo.util.SDOUtil; This needs resolving in a generic way; we cant have any tuscany stuff appearing in the sdo2.1-cts project. I guess this needs extension to the TestHelper interface, and then a Tuscany implementation of the new TestHelper methods. Can you look at this please?
As I mentioned after my eyeballing of the patch, I am missing testApplication.junit.runner.CategorizedParameterized. Can you supply this please?
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: cts.patch, cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Brian Murray (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Murray updated TUSCANY-1241:
----------------------------------
Attachment: cts.patch
Attaching the patch.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493372 ]
Kelvin Goodson commented on TUSCANY-1241:
-----------------------------------------
Brian, thanks for this. I have had a good look at the changes you are proposing. Most of the stuctural changes are in line with what I have already put in place.
You will see that I have deprecated BaseSDOParametizedTest class in favour of the new ParameterizedTestBase.
As you pointed out, this update comes at a time when there is much change and much discussion about further change, including the suggestion of not using the junit 4.1 parameterized testing feature, and providing similar behaviour where required through java features alone. I'm in favour of this latter approach, so I think we need to work out a staged way of getting to that position without losing useful updates.
I took a detailed look at the first dozen or so of your classes and I think that the best approach may be for me to judiciously apply your changes as they are here as much as and as best as I can. I will retain the BaseSDOParameterizedTest as the superclass for all test cases other than the two that I have already moved to be specializations of ParameterizedTestBase. We can then work out whether we move away from the deprecated base class by converging on the new ParameterizedTestBase or whether we work towards removing the reliance upon the junit parameterized feature.
By the way, I can't see where the CategorizedParameterized runner comes from yet. Is this something or yours that is missing from the patch?
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: cts.patch, cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Brian Murray (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Murray updated TUSCANY-1241:
----------------------------------
Attachment: cts.patch
Attaching a new version of cts.patch. This version includes a ParamaterizedTestUtil cleansed of Tuscany references.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: CategorizedParameterized.java, cts.patch, cts.patch, cts.patch, TuscanyLeak.zip
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Brian Murray (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Murray updated TUSCANY-1241:
----------------------------------
Attachment: cts.patch
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: cts.patch, cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Brian Murray (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Murray updated TUSCANY-1241:
----------------------------------
Attachment: TuscanyLeak.zip
The seperation of the vendor specific (Tuscany) classes was not complete.
BaseSDOParamatizedTest.java made reference to TuscanyDataObjectFactory. The TestHelper class has been updated to include a method to create a DataObjectFactory.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: CategorizedParameterized.java, cts.patch, cts.patch, TuscanyLeak.zip
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson resolved TUSCANY-1241.
-------------------------------------
Resolution: Fixed
Fix Version/s: Java-SDO-CTS-Mx
Merged Brian's updates with mine.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Fix For: Java-SDO-CTS-Mx
>
> Attachments: CategorizedParameterized.java, cts.patch, cts.patch, cts.patch, TuscanyLeak.zip
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493643 ]
Kelvin Goodson commented on TUSCANY-1241:
-----------------------------------------
Brian, thanks for the update. I merged the updates you supplied in the zip file with my workspace (slight nitpick -- it's far easier to apply patches rather than zip files, since then the 3 way diff can be done by tooling rather than human eye). So we just have the ParamatizedTestUtil class to cleanse. I'll continue with commented out code / tests for now in order to progress what I can until you can fix that one up too.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: CategorizedParameterized.java, cts.patch, cts.patch, TuscanyLeak.zip
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1241) Provide CTS Updates for
HelperContext and a new DO creation mechanism
Posted by "Brian Murray (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Murray updated TUSCANY-1241:
----------------------------------
Attachment: CategorizedParameterized.java
Attaching the CategorizedParameterized runner.
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: CategorizedParameterized.java, cts.patch, cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some updates. I'd like to provide those changes back to Tuscany. Those changes include test case corrections and additions, the use of HelperContext, and the use of a new DataObjectFactory class . The DataObjectFactory class has Method and Object[] members that are populated via the constructor. The class has methods with void parameter lists to create different Types of DataObjects relevant to the test cases. In this way, the individual test cases need not be aware of the creation or definition mechanism of the DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing our changes. (So that I may provide the required usage agreements with the patch.)
> Note that the patch is not complete. However, I'm aware that discussion has picked up and I want to provide my changes as quickly so as to avoid unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org