[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10473: Support continuous profiling feature

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #10473:
URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123029324


##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBEBPFProfilingTaskDAO.java:
##########
@@ -108,24 +109,15 @@ protected void apply(StreamQuery query) {
     }
 
     @Override
-    public EBPFProfilingTask queryById(String id) throws IOException {
+    public List<EBPFProfilingTaskRecord> queryByLogicalId(String id) throws IOException {

Review Comment:
   What does logic ID mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org