You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "romankarlstetter (via GitHub)" <gi...@apache.org> on 2023/09/12 08:12:04 UTC
[GitHub] [arrow] romankarlstetter opened a new pull request, #37674: GH-37673: [C++][Flight] Improve error message if binding port fails
romankarlstetter opened a new pull request, #37674:
URL: https://github.com/apache/arrow/pull/37674
See https://github.com/apache/arrow/issues/37673 for more info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37674: GH-37673: [C++][Flight] Improve error message if binding port fails
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37674:
URL: https://github.com/apache/arrow/pull/37674#issuecomment-1715221401
:warning: GitHub issue #37673 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romankarlstetter closed pull request #37674: GH-37673: [C++][FlightRPC] Improve error message if binding port fails
Posted by "romankarlstetter (via GitHub)" <gi...@apache.org>.
romankarlstetter closed pull request #37674: GH-37673: [C++][FlightRPC] Improve error message if binding port fails
URL: https://github.com/apache/arrow/pull/37674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #37674: GH-37673: [C++][FlightRPC] Improve error message if binding port fails
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #37674:
URL: https://github.com/apache/arrow/pull/37674#discussion_r1323072311
##########
cpp/src/arrow/flight/transport/grpc/grpc_server.cc:
##########
@@ -616,6 +616,10 @@ class GrpcServerTransport : public internal::ServerTransport {
grpc_server_ = builder.BuildAndStart();
if (!grpc_server_) {
+ if (port == 0) {
+ return Status::Invalid("Server did not start properly. Unable to bind to port ",
Review Comment:
I think IOError makes more sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romankarlstetter commented on pull request #37674: GH-37673: [C++][FlightRPC] Improve error message if binding port fails
Posted by "romankarlstetter (via GitHub)" <gi...@apache.org>.
romankarlstetter commented on PR #37674:
URL: https://github.com/apache/arrow/pull/37674#issuecomment-1717027973
Sorry, renaming the master branch in my local fork was a bad idea, I guess... recreated the pull request (with the suggested changed) here: #37689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romankarlstetter commented on a diff in pull request #37674: GH-37673: [C++][FlightRPC] Improve error message if binding port fails
Posted by "romankarlstetter (via GitHub)" <gi...@apache.org>.
romankarlstetter commented on code in PR #37674:
URL: https://github.com/apache/arrow/pull/37674#discussion_r1324034444
##########
cpp/src/arrow/flight/transport/grpc/grpc_server.cc:
##########
@@ -616,6 +616,10 @@ class GrpcServerTransport : public internal::ServerTransport {
grpc_server_ = builder.BuildAndStart();
if (!grpc_server_) {
+ if (port == 0) {
+ return Status::Invalid("Server did not start properly. Unable to bind to port ",
Review Comment:
`IOError` is also fine for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org