You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2021/03/18 05:42:39 UTC
[james-project] 03/07: JAMES-3509 ImapRequestFrameDecoder: remove a
TODO: remove me comment
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to annotated tag james-project-3.6.0
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 4621c2b565a34e98c98d2386fff7513c26e4cb46
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Sun Feb 28 22:24:59 2021 +0700
JAMES-3509 ImapRequestFrameDecoder: remove a TODO: remove me comment
---
.../james/imapserver/netty/ImapRequestFrameDecoder.java | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java
index fe77950..0b97410 100644
--- a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java
+++ b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java
@@ -182,13 +182,6 @@ public class ImapRequestFrameDecoder extends FrameDecoder implements NettyConsta
reader.consumeLine();
}
- // Code portion commented further to JAMES-1436.
- // TODO Remove if no negative feedback on JAMES-1436.
- //ChannelHandler handler = (ChannelHandler) attachment.remove(FRAMER);
- //if (handler != null) {
- // channel.getPipeline().addFirst(FRAMER, handler);
- //}
-
((SwitchableLineBasedFrameDecoder) channel.getPipeline().get(FRAMER)).enableFraming();
attachment.clear();
@@ -202,11 +195,6 @@ public class ImapRequestFrameDecoder extends FrameDecoder implements NettyConsta
final ChannelPipeline pipeline = channel.getPipeline();
final ChannelHandlerContext framerContext = pipeline.getContext(FRAMER);
-
- // Code portion commented further to JAMES-1436.
- // TODO Remove if no negative feedback on JAMES-1436.
- //ChannelHandler handler = channel.getPipeline().remove(FRAMER);
- //attachment.put(FRAMER, handler);
// SwitchableDelimiterBasedFrameDecoder added further to JAMES-1436.
final SwitchableLineBasedFrameDecoder framer = (SwitchableLineBasedFrameDecoder) pipeline.get(FRAMER);
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org