You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "KazMiddelhoek (via GitHub)" <gi...@apache.org> on 2023/12/20 14:28:48 UTC
[PR] Fix typo in pyspark.sql.functions.greatest docstring [spark]
KazMiddelhoek opened a new pull request, #44427:
URL: https://github.com/apache/spark/pull/44427
### What changes were proposed in this pull request?
The description of f.greatest had two small typo's in them. This PR fixes these typo's.
### Why are the changes needed?
Proper English should be used in documentation.
### Does this PR introduce _any_ user-facing change?
Yes, the correct english word is now used in the pyspark docs.
### How was this patch tested?
Not tested
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON][DOCS] Fix typo in pyspark.sql.functions.greatest docstring [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44427: [MINOR][PYTHON][DOCS] Fix typo in pyspark.sql.functions.greatest docstring
URL: https://github.com/apache/spark/pull/44427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][PYTHON][DOCS] Fix typo in pyspark.sql.functions.greatest docstring [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44427:
URL: https://github.com/apache/spark/pull/44427#issuecomment-1865327720
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typo in pyspark.sql.functions.greatest docstring [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44427:
URL: https://github.com/apache/spark/pull/44427#issuecomment-1864789459
> typo's
Since the subject of this PR is proper English, I will be "that guy" for just a moment and say: typos. There is no contraction or possession. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typo in pyspark.sql.functions.greatest docstring [spark]
Posted by "rompear (via GitHub)" <gi...@apache.org>.
rompear commented on PR #44427:
URL: https://github.com/apache/spark/pull/44427#issuecomment-1864605146
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix typo in pyspark.sql.functions.greatest docstring [spark]
Posted by "KazMiddelhoek (via GitHub)" <gi...@apache.org>.
KazMiddelhoek commented on PR #44427:
URL: https://github.com/apache/spark/pull/44427#issuecomment-1864851171
> > typo's
>
> Since the subject of this PR is proper English, I will be "that guy" for just a moment and say: typos. There is no contraction or possession. 😄
Haha fair enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org