You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Owen O'Malley (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 00:17:29 UTC
[jira] [Created] (HIVE-2911) Move global .hiverc file
Move global .hiverc file
------------------------
Key: HIVE-2911
URL: https://issues.apache.org/jira/browse/HIVE-2911
Project: Hive
Issue Type: Improvement
Components: CLI
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Currently, the .hiverc files are loaded from:
{code}
$HIVE_HOME/bin/.hiverc
~/.hiverc
{code}
It seems more ops-friendly to have it in the config directory.
{code}
$HIVE_HOME/bin/.hiverc <- for backwards compatibility
$HIVE_CONF_DIR/.hiverc
~/.hiverc
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2911) Move global .hiverc file
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294033#comment-13294033 ]
Namit Jain commented on HIVE-2911:
----------------------------------
+1
Owen, my bad. I dont know why I thought it was incompatible.
Edward, I am assuming you will take care of committing this.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2911) Move global .hiverc file
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2911:
------------------------------
Attachment: HIVE-2911.D2529.2.patch
omalley updated the revision "HIVE-2911 [jira] Move global .hiverc file".
Reviewers: JIRA
Changed the printInfo to printError so that the user actually sees the warning.
REVISION DETAIL
https://reviews.facebook.net/D2529
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2911) Move global .hiverc file
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2911:
------------------------------
Attachment: HIVE-2911.D2529.1.patch
omalley requested code review of "HIVE-2911 [jira] Move global .hiverc file".
Reviewers: JIRA
HIVE-2911
Move the location of the global hiverc file to $HIVE_CONF_DIR/.hiverc.
Currently, the .hiverc files are loaded from:
$HIVE_HOME/bin/.hiverc
~/.hiverc
It seems more ops-friendly to have it in the config directory.
$HIVE_HOME/bin/.hiverc <- for backwards compatibility
$HIVE_CONF_DIR/.hiverc
~/.hiverc
TEST PLAN
Can't test cli driver.
REVISION DETAIL
https://reviews.facebook.net/D2529
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5733/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2911) Move global .hiverc file
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292621#comment-13292621 ]
Edward Capriolo commented on HIVE-2911:
---------------------------------------
+1. I think we are fine here. We are just adding and extra place to possibly load the .hiverc file from and suggesting a new position which makes more sense. (I do not remember my rational for loading the .hiverc file from /bin) I will take a look tomorrow.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2911) Move global .hiverc file
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242951#comment-13242951 ]
Namit Jain commented on HIVE-2911:
----------------------------------
This is a backward incompatible change.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2911) Move global .hiverc file
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294617#comment-13294617 ]
Hudson commented on HIVE-2911:
------------------------------
Integrated in Hive-trunk-h0.21 #1484 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1484/])
HIVE-2911 Move Global .hiverc file (Owen O'Malley via egc) (Revision 1349611)
Result = FAILURE
ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349611
Files :
* /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Affects Versions: 0.10.0
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2911) Move global .hiverc file
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272697#comment-13272697 ]
Owen O'Malley commented on HIVE-2911:
-------------------------------------
Namit,
How is it backward incompatible? It still reads the file from $HIVE_HOME/bin/.hiverc, if it is there.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2911) Move global .hiverc file
Posted by "Owen O'Malley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HIVE-2911:
--------------------------------
Status: Patch Available (was: Open)
I tested this on a cluster and it worked as expected.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2911) Move global .hiverc file
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo updated HIVE-2911:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Affects Versions: 0.10.0
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2911) Move global .hiverc file
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo updated HIVE-2911:
----------------------------------
Affects Version/s: 0.10.0
Fix Version/s: 0.10.0
Committed. Nice work Owen.
> Move global .hiverc file
> ------------------------
>
> Key: HIVE-2911
> URL: https://issues.apache.org/jira/browse/HIVE-2911
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Affects Versions: 0.10.0
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.10.0
>
> Attachments: HIVE-2911.D2529.1.patch, HIVE-2911.D2529.2.patch
>
>
> Currently, the .hiverc files are loaded from:
> {code}
> $HIVE_HOME/bin/.hiverc
> ~/.hiverc
> {code}
> It seems more ops-friendly to have it in the config directory.
> {code}
> $HIVE_HOME/bin/.hiverc <- for backwards compatibility
> $HIVE_CONF_DIR/.hiverc
> ~/.hiverc
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira