You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/16 01:23:04 UTC
[jira] [Commented] (DRILL-5512) Standardize error handling in
ScanBatch
[ https://issues.apache.org/jira/browse/DRILL-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011586#comment-16011586 ]
ASF GitHub Bot commented on DRILL-5512:
---------------------------------------
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/838
DRILL-5512: Standardize error handling in ScanBatch
Standardizes error handling to throw a UserException. Prior code threw
various exceptions, called the fail() method, or returned a variety of
status codes.
Note: this PR depends upon DRILL-5511, PR #836. For this PR, please review only the changes introduced in DRILL-5512. Commit this after committing DRILL-5511.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #838
----
commit b31d40df314d76ae6c458891e65d423b4b9e61cb
Author: Paul Rogers <pr...@maprtech.com>
Date: 2017-05-15T21:23:10Z
DRILL-5511: Additional UserException categories
Adds three kinds of internal errors:
1. General execution exception: something failed due to issues outside
Drill.
2. Internal error: something failed due to a likely code error.
3. Unspecified: something failed, but we don’t know why.
commit b8a3f15526d83369ce124e777e9d6e7afa84d7e0
Author: Paul Rogers <pr...@maprtech.com>
Date: 2017-05-15T22:00:21Z
DRILL-5512: Standardize error handling in ScanBatch
Standardizes error handling to throw a UserException. Prior code threw
various exceptions, called the fail() method, or returned a variety of
status codes.
----
> Standardize error handling in ScanBatch
> ---------------------------------------
>
> Key: DRILL-5512
> URL: https://issues.apache.org/jira/browse/DRILL-5512
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.10.0
>
>
> ScanBatch is the Drill operator executor that handles most readers. Like most Drill operators, it uses an ad-hoc set of error detection and reporting methods that evolved over Drill development.
> This ticket asks to standardize on error handling as outlined in DRILL-5083. This basically means reporting all errors as a {{UserException}} rather than using the {{IterOutcome.STOP}} return status or using the {{FragmentContext.fail()}} method.
> This work requires the new error codes introduced in DRILL-5511, and is a step toward making readers aware of vector size limits.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)