[GitHub] [pinot] xiangfu0 commented on a change in pull request #7593: In ServiceStartable, apply global cluster config in ZK to instance config

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #7593:
URL: https://github.com/apache/pinot/pull/7593#discussion_r731384302



##########
File path: pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
##########
@@ -83,8 +84,11 @@
   public void init(PinotConfiguration config)
       throws Exception {
     _config = new MinionConf(config.toMap());
-    String helixClusterName = _config.getHelixClusterName();
     String zkAddress = _config.getZkAddress();
+    String helixClusterName = _config.getHelixClusterName();
+    ServiceStartableUtils.applyClusterConfig(_config, zkAddress, helixClusterName, ServiceRole.MINION);
+
+    setupHelixSystemProperties();

Review comment:
       Should this `setupHelixSystemProperties()` method already covered by the `ServiceStartableUtils.applyClusterConfig(...)` call?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org