You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/28 15:19:30 UTC
[GitHub] [spark] MaxGekk opened a new pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
MaxGekk opened a new pull request #30527:
URL: https://github.com/apache/spark/pull/30527
### What changes were proposed in this pull request?
Remove the unused method `getTables()` from `r.SQLUtils`. The method was used before the changes https://github.com/apache/spark/pull/17483 but R's `tables.default` was rewritten using `listTables()`: https://github.com/apache/spark/pull/17483/files#diff-2c01472a7bcb1d318244afcd621d726e00d36cd15dffe7e44fa96c54fce4cd9aR220-R223
### Why are the changes needed?
To improve code maintenance, and remove the dead code.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By R tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735303498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735286603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735244142
**[Test build #131908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131908/testReport)** for PR 30527 at commit [`bedd63b`](https://github.com/apache/spark/commit/bedd63b514b0cbf41a986ba38682325088371fc2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735273300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735287450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735258496
**[Test build #131909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131909/testReport)** for PR 30527 at commit [`cc3112d`](https://github.com/apache/spark/commit/cc3112d629e6d282d3f2cbe5efa0f6880f88936c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30527:
URL: https://github.com/apache/spark/pull/30527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735279501
**[Test build #131912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131912/testReport)** for PR 30527 at commit [`7693c04`](https://github.com/apache/spark/commit/7693c04044e066338cd3a78c5f0e881b18634852).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735273300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735244763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735258243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735286480
**[Test build #131909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131909/testReport)** for PR 30527 at commit [`cc3112d`](https://github.com/apache/spark/commit/cc3112d629e6d282d3f2cbe5efa0f6880f88936c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735244763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735258496
**[Test build #131909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131909/testReport)** for PR 30527 at commit [`cc3112d`](https://github.com/apache/spark/commit/cc3112d629e6d282d3f2cbe5efa0f6880f88936c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735303498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735244142
**[Test build #131908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131908/testReport)** for PR 30527 at commit [`bedd63b`](https://github.com/apache/spark/commit/bedd63b514b0cbf41a986ba38682325088371fc2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735258243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735279501
**[Test build #131912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131912/testReport)** for PR 30527 at commit [`7693c04`](https://github.com/apache/spark/commit/7693c04044e066338cd3a78c5f0e881b18634852).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735286603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735244757
**[Test build #131908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131908/testReport)** for PR 30527 at commit [`bedd63b`](https://github.com/apache/spark/commit/bedd63b514b0cbf41a986ba38682325088371fc2).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30527: [MINOR][SQL] Remove `getTables()` from `r.SQLUtils`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30527:
URL: https://github.com/apache/spark/pull/30527#issuecomment-735302425
**[Test build #131912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131912/testReport)** for PR 30527 at commit [`7693c04`](https://github.com/apache/spark/commit/7693c04044e066338cd3a78c5f0e881b18634852).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org