You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/07 15:18:20 UTC
[GitHub] [iotdb] CloudWise-Lukemiao opened a new pull request, #6907: [IOTDB-2952] IOTDB Grafana Plugin: Build on Windows
CloudWise-Lukemiao opened a new pull request, #6907:
URL: https://github.com/apache/iotdb/pull/6907
IOTDB Grafana Plugin: Build on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CloudWise-Lukemiao commented on a diff in pull request #6907: [IOTDB-2952] IOTDB Grafana Plugin: Build on Windows
Posted by GitBox <gi...@apache.org>.
CloudWise-Lukemiao commented on code in PR #6907:
URL: https://github.com/apache/iotdb/pull/6907#discussion_r940825201
##########
grafana-plugin/pom.xml:
##########
@@ -135,6 +110,35 @@
</filesets>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>1.3</version>
+ <executions>
+ <execution>
+ <id>test</id>
+ <phase>package</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <tasks>
+ <condition property="osFamily" value="windows">
+ <os family="windows"/>
+ </condition>
+ <condition property="osFamily" value="unix">
+ <os family="unix"/>
+ </condition>
+ <exec executable="C:\\Windows\\System32\\cmd.exe" osfamily="windows">
+ <arg line="/c backend-compile.bat"/>
Review Comment:
Sorry, I forgot to submit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #6907: [IOTDB-2952] IOTDB Grafana Plugin: Build on Windows
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #6907:
URL: https://github.com/apache/iotdb/pull/6907#discussion_r940818559
##########
grafana-plugin/pom.xml:
##########
@@ -135,6 +110,35 @@
</filesets>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>1.3</version>
+ <executions>
+ <execution>
+ <id>test</id>
+ <phase>package</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <tasks>
+ <condition property="osFamily" value="windows">
+ <os family="windows"/>
+ </condition>
+ <condition property="osFamily" value="unix">
+ <os family="unix"/>
+ </condition>
+ <exec executable="C:\\Windows\\System32\\cmd.exe" osfamily="windows">
+ <arg line="/c backend-compile.bat"/>
Review Comment:
Is `backend-compile.bat` missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6907: [IOTDB-2952] IOTDB Grafana Plugin: Build on Windows
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6907:
URL: https://github.com/apache/iotdb/pull/6907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org