You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/27 17:53:49 UTC
[GitHub] [hbase] saintstack opened a new pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
saintstack opened a new pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374
…d NullPointerException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#discussion_r399483314
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
##########
@@ -80,13 +77,10 @@ void setPrefetchListener(Consumer<Boolean> prefetchListener) {
@Override
protected void initCache() {
- // concurrent cache
- maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
+ // Override to put a different cache in place of the super's -- a concurrent one.
cache = new LinkedBlockingQueue<>();
+ maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
cacheSizeInBytes = new AtomicLong(0);
- exceptionsQueue = new ConcurrentLinkedQueue<>();
- prefetcher = new Thread(new PrefetchRunnable());
Review comment:
We don't need to keep a handle on the spawned thread? It's a daemon so need to explicitly terminate it on shutdown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#issuecomment-605198406
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 18s | branch-2 passed |
| +1 :green_heart: | compile | 0m 25s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 26s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 50s | the patch passed |
| +1 :green_heart: | compile | 0m 26s | the patch passed |
| +1 :green_heart: | javac | 0m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 7s | hbase-client in the patch passed. |
| | | 28m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1374 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 52c8ede908a7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 244e47ca65 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/testReport/ |
| Max. process+thread count | 384 (vs. ulimit of 10000) |
| modules | C: hbase-client U: hbase-client |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#discussion_r401358236
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
##########
@@ -80,13 +77,10 @@ void setPrefetchListener(Consumer<Boolean> prefetchListener) {
@Override
protected void initCache() {
- // concurrent cache
- maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
+ // Override to put a different cache in place of the super's -- a concurrent one.
cache = new LinkedBlockingQueue<>();
+ maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
cacheSizeInBytes = new AtomicLong(0);
- exceptionsQueue = new ConcurrentLinkedQueue<>();
- prefetcher = new Thread(new PrefetchRunnable());
Review comment:
Nothing was done w/ the reference previously. Yeah, its daemon so should be just dying when process goes away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#issuecomment-605202443
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 30s | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 36s | branch-2 passed |
| +1 :green_heart: | spotbugs | 1m 10s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 51s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 36s | hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 0s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. |
| +1 :green_heart: | spotbugs | 1m 18s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
| | | 37m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1374 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 497cbd1df984 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 244e47ca65 |
| Max. process+thread count | 83 (vs. ulimit of 10000) |
| modules | C: hbase-client U: hbase-client |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#issuecomment-605200475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 15s | branch-2 passed |
| +1 :green_heart: | compile | 0m 32s | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 30s | hbase-client in branch-2 failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 31s | the patch passed |
| +1 :green_heart: | javac | 0m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 55s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 15s | hbase-client in the patch passed. |
| | | 32m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1374 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 818b90f02fbb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 244e47ca65 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/testReport/ |
| Max. process+thread count | 337 (vs. ulimit of 10000) |
| modules | C: hbase-client U: hbase-client |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1374/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services