You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/16 03:47:52 UTC
Re: Review Request 34427: AppC provisioner backend using bind mounts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34427/#review88020
-----------------------------------------------------------
src/slave/containerizer/provisioners/appc/bind_backend.hpp
<https://reviews.apache.org/r/34427/#comment140424>
Given that you dont declare any templates, would it make sense to split this into cpp+hpp?
src/slave/containerizer/provisioners/appc/bind_backend.hpp
<https://reviews.apache.org/r/34427/#comment140425>
- Till Toenshoff
On May 19, 2015, 6:46 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34427/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 6:46 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note: This is a specialized backend; see notes in bind_backend.hpp.
>
> Reproduced here for your convenience:
>
> This is a specialized backend that may be useful for deployments
> using large (multi-GB) single-layer images *and* where more
> recent kernel features such as overlayfs are not available. For small
> images (10's to 100's of MB) the Copy backend may be sufficient.
> 1) It supports only a single layer. Multi-layer images will fail
> to provision and the container will fail to launch!
> 2) The filesystem is read-only because all containers using this
> image share the source. Select writable areas can be achieved
> by
> mounting read-write volumes to places like /tmp, /var/tmp,
> /home, etc. using the ContainerInfo. These can be relative to
> the executor work directory.
> 3) It relies on the image persisting in the store.
> 4) It's fast because the bind mount requires (nearly) zero IO.
>
>
> Diffs
> -----
>
> src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496
> src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION
> src/slave/containerizer/provisioners/appc/bind_backend.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34427/diff/
>
>
> Testing
> -------
>
> manual testing of a single layer image with RW relative bind mount for /tmp.
>
>
> Thanks,
>
> Ian Downes
>
>