You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:54:19 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
nsivabalan opened a new pull request #4588:
URL: https://github.com/apache/hudi/pull/4588
## What is the purpose of the pull request
Looks like conflict resolution had a bug in auto commit code path. Incidentally both spark datasource writer and deltastreamer uses non auto commit code path and hence this was never an issue. Fixing the same in this patch and added tests to verify the fix.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012067546
@manojpec : Can you review this patch please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018892020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
}, {
"hash" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
* 11e20c0e55fc2502f5a2891a85ffe6c9a7024848 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017812847
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018959951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
}, {
"hash" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426",
"triggerID" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11e20c0e55fc2502f5a2891a85ffe6c9a7024848 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#discussion_r788788149
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -60,9 +60,31 @@
final Option<HoodieCommitMetadata> thisCommitMetadata,
final HoodieWriteConfig config,
Option<HoodieInstant> lastCompletedTxnOwnerInstant) throws HoodieWriteConflictException {
+ return resolveWriteConflictIfAny(table, currentTxnOwnerInstant, thisCommitMetadata, config, lastCompletedTxnOwnerInstant, false);
+ }
+
+ /**
+ * Resolve any write conflicts when committing data.
+ *
+ * @param table
+ * @param currentTxnOwnerInstant
+ * @param thisCommitMetadata
+ * @param config
+ * @param lastCompletedTxnOwnerInstant
+ * @return
+ * @throws HoodieWriteConflictException
+ */
+ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
+ final HoodieTable table,
+ final Option<HoodieInstant> currentTxnOwnerInstant,
+ final Option<HoodieCommitMetadata> thisCommitMetadata,
+ final HoodieWriteConfig config,
+ Option<HoodieInstant> lastCompletedTxnOwnerInstant,
+ boolean reloadActiveTimeline) throws HoodieWriteConflictException {
Review comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
codope merged pull request #4588:
URL: https://github.com/apache/hudi/pull/4588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012072048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012069774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#discussion_r786307490
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -60,9 +60,31 @@
final Option<HoodieCommitMetadata> thisCommitMetadata,
final HoodieWriteConfig config,
Option<HoodieInstant> lastCompletedTxnOwnerInstant) throws HoodieWriteConflictException {
+ return resolveWriteConflictIfAny(table, currentTxnOwnerInstant, thisCommitMetadata, config, lastCompletedTxnOwnerInstant, false);
+ }
+
+ /**
+ * Resolve any write conflicts when committing data.
+ *
+ * @param table
+ * @param currentTxnOwnerInstant
+ * @param thisCommitMetadata
+ * @param config
+ * @param lastCompletedTxnOwnerInstant
+ * @return
+ * @throws HoodieWriteConflictException
+ */
+ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
+ final HoodieTable table,
+ final Option<HoodieInstant> currentTxnOwnerInstant,
+ final Option<HoodieCommitMetadata> thisCommitMetadata,
+ final HoodieWriteConfig config,
+ Option<HoodieInstant> lastCompletedTxnOwnerInstant,
+ boolean reloadActiveTimeline) throws HoodieWriteConflictException {
Review comment:
non auto commit code path, already has latest view. reloading of timeline is costly and we don't want to reload unless or other wise necessary. and hence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017871729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#discussion_r786307558
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
##########
@@ -441,6 +445,135 @@ public void testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
}
}
+ @Test
+ public void testHoodieClientMultiWriterAutoCommitForConflict() throws Exception {
+ Properties properties = new Properties();
+ properties.setProperty(FILESYSTEM_LOCK_PATH_PROP_KEY, basePath + "/.hoodie/.locks");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY, "3000");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY, "100");
+ HoodieWriteConfig.Builder writeConfigBuilder = getConfigBuilder()
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder().withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.LAZY)
+ .withAutoClean(false).build())
+ .withWriteConcurrencyMode(WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(false).build())
Review comment:
will fix it. Copied from else where I guess.
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
##########
@@ -441,6 +445,135 @@ public void testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
}
}
+ @Test
+ public void testHoodieClientMultiWriterAutoCommitForConflict() throws Exception {
+ Properties properties = new Properties();
+ properties.setProperty(FILESYSTEM_LOCK_PATH_PROP_KEY, basePath + "/.hoodie/.locks");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY, "3000");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY, "100");
+ HoodieWriteConfig.Builder writeConfigBuilder = getConfigBuilder()
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder().withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.LAZY)
+ .withAutoClean(false).build())
+ .withWriteConcurrencyMode(WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(false).build())
+ // Timeline-server-based markers are not used for multi-writer tests
+ .withMarkersType(MarkerType.DIRECT.name())
+ .withLockConfig(HoodieLockConfig.newBuilder().withLockProvider(InProcessLockProvider.class)
+ .build()).withAutoCommit(true).withProperties(properties);
+ HoodieWriteConfig cfg = writeConfigBuilder.build();
+ HoodieWriteConfig cfg2 = writeConfigBuilder.build();
+
+ // Create the first commit
+ createCommitWithInserts(cfg, getHoodieWriteClient(cfg), "000", "001", 5000, false);
+ // Start another inflight commit
+ String newCommitTime1 = "003";
+ String newCommitTime2 = "004";
+ SparkRDDWriteClient client1 = getHoodieWriteClient(cfg);
+ SparkRDDWriteClient client2 = getHoodieWriteClient(cfg2);
+
+ List<HoodieRecord> updates1 = dataGen.generateUpdates(newCommitTime1, 5000);
+ List<HoodieRecord> updates2 = dataGen.generateUpdates(newCommitTime2, 5000);
+
+ JavaRDD<HoodieRecord> writeRecords1 = jsc.parallelize(updates1, 4);
+ JavaRDD<HoodieRecord> writeRecords2 = jsc.parallelize(updates2, 4);
+
+ runConcurrentAndAssert(writeRecords1, writeRecords2, client1, client2, SparkRDDWriteClient::upsert, true);
+ }
+
+ private void runConcurrentAndAssert(JavaRDD<HoodieRecord> writeRecords1, JavaRDD<HoodieRecord> writeRecords2,
+ SparkRDDWriteClient client1, SparkRDDWriteClient client2,
+ Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>, String> writeFn,
+ boolean assertForConflict) throws ExecutionException, InterruptedException {
+
+ CountDownLatch runCountDownLatch = new CountDownLatch(2);
+ final ExecutorService executors = Executors.newFixedThreadPool(2);
+ String newCommitTime1 = "003";
+ String newCommitTime2 = "004";
+
+ AtomicBoolean client1Succeeded = new AtomicBoolean(true);
+ AtomicBoolean client2Succeeded = new AtomicBoolean(true);
+
+ Future future1 = executors.submit(() -> {
+ try {
+ ingestBatch(writeFn, client1, newCommitTime1, writeRecords1, runCountDownLatch);
+ } catch (IOException e) {
+ e.printStackTrace();
Review comment:
will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012069774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017810257
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018893708
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
}, {
"hash" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426",
"triggerID" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
* 11e20c0e55fc2502f5a2891a85ffe6c9a7024848 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#discussion_r785749484
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
##########
@@ -441,6 +445,135 @@ public void testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
}
}
+ @Test
+ public void testHoodieClientMultiWriterAutoCommitForConflict() throws Exception {
+ Properties properties = new Properties();
+ properties.setProperty(FILESYSTEM_LOCK_PATH_PROP_KEY, basePath + "/.hoodie/.locks");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY, "3000");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY, "100");
+ HoodieWriteConfig.Builder writeConfigBuilder = getConfigBuilder()
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder().withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.LAZY)
+ .withAutoClean(false).build())
+ .withWriteConcurrencyMode(WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(false).build())
Review comment:
Why disable metadata?
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
##########
@@ -441,6 +445,135 @@ public void testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
}
}
+ @Test
+ public void testHoodieClientMultiWriterAutoCommitForConflict() throws Exception {
+ Properties properties = new Properties();
+ properties.setProperty(FILESYSTEM_LOCK_PATH_PROP_KEY, basePath + "/.hoodie/.locks");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY, "3000");
+ properties.setProperty(LockConfiguration.LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY, "100");
+ HoodieWriteConfig.Builder writeConfigBuilder = getConfigBuilder()
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder().withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.LAZY)
+ .withAutoClean(false).build())
+ .withWriteConcurrencyMode(WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(false).build())
+ // Timeline-server-based markers are not used for multi-writer tests
+ .withMarkersType(MarkerType.DIRECT.name())
+ .withLockConfig(HoodieLockConfig.newBuilder().withLockProvider(InProcessLockProvider.class)
+ .build()).withAutoCommit(true).withProperties(properties);
+ HoodieWriteConfig cfg = writeConfigBuilder.build();
+ HoodieWriteConfig cfg2 = writeConfigBuilder.build();
+
+ // Create the first commit
+ createCommitWithInserts(cfg, getHoodieWriteClient(cfg), "000", "001", 5000, false);
+ // Start another inflight commit
+ String newCommitTime1 = "003";
+ String newCommitTime2 = "004";
+ SparkRDDWriteClient client1 = getHoodieWriteClient(cfg);
+ SparkRDDWriteClient client2 = getHoodieWriteClient(cfg2);
+
+ List<HoodieRecord> updates1 = dataGen.generateUpdates(newCommitTime1, 5000);
+ List<HoodieRecord> updates2 = dataGen.generateUpdates(newCommitTime2, 5000);
+
+ JavaRDD<HoodieRecord> writeRecords1 = jsc.parallelize(updates1, 4);
+ JavaRDD<HoodieRecord> writeRecords2 = jsc.parallelize(updates2, 4);
+
+ runConcurrentAndAssert(writeRecords1, writeRecords2, client1, client2, SparkRDDWriteClient::upsert, true);
+ }
+
+ private void runConcurrentAndAssert(JavaRDD<HoodieRecord> writeRecords1, JavaRDD<HoodieRecord> writeRecords2,
+ SparkRDDWriteClient client1, SparkRDDWriteClient client2,
+ Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>, String> writeFn,
+ boolean assertForConflict) throws ExecutionException, InterruptedException {
+
+ CountDownLatch runCountDownLatch = new CountDownLatch(2);
+ final ExecutorService executors = Executors.newFixedThreadPool(2);
+ String newCommitTime1 = "003";
+ String newCommitTime2 = "004";
+
+ AtomicBoolean client1Succeeded = new AtomicBoolean(true);
+ AtomicBoolean client2Succeeded = new AtomicBoolean(true);
+
+ Future future1 = executors.submit(() -> {
+ try {
+ ingestBatch(writeFn, client1, newCommitTime1, writeRecords1, runCountDownLatch);
+ } catch (IOException e) {
+ e.printStackTrace();
Review comment:
Maybe just log error instead of printStackTrace.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -60,9 +60,31 @@
final Option<HoodieCommitMetadata> thisCommitMetadata,
final HoodieWriteConfig config,
Option<HoodieInstant> lastCompletedTxnOwnerInstant) throws HoodieWriteConflictException {
+ return resolveWriteConflictIfAny(table, currentTxnOwnerInstant, thisCommitMetadata, config, lastCompletedTxnOwnerInstant, false);
+ }
+
+ /**
+ * Resolve any write conflicts when committing data.
+ *
+ * @param table
+ * @param currentTxnOwnerInstant
+ * @param thisCommitMetadata
+ * @param config
+ * @param lastCompletedTxnOwnerInstant
+ * @return
+ * @throws HoodieWriteConflictException
+ */
+ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
+ final HoodieTable table,
+ final Option<HoodieInstant> currentTxnOwnerInstant,
+ final Option<HoodieCommitMetadata> thisCommitMetadata,
+ final HoodieWriteConfig config,
+ Option<HoodieInstant> lastCompletedTxnOwnerInstant,
+ boolean reloadActiveTimeline) throws HoodieWriteConflictException {
Review comment:
Why need a boolean? Can we not reload active timeline irrespective of auto commit enabled or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017810257
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012125118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
codope commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018529740
@nsivabalan Changes look good. But `TestHoodieBackedMetadata.testMetadataMultiWriter()` is failing. Can yuu please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017812847
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012072048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1012125118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee0c9a377143296268d56e1402c2ab55a0980476 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018892020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
}, {
"hash" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
* 11e20c0e55fc2502f5a2891a85ffe6c9a7024848 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1017871729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4588: [HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4588:
URL: https://github.com/apache/hudi/pull/4588#issuecomment-1018893708
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5194",
"triggerID" : "ee0c9a377143296268d56e1402c2ab55a0980476",
"triggerType" : "PUSH"
}, {
"hash" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389",
"triggerID" : "3c51e8e28c5440500e4c2b8ff4ec606f222d56a8",
"triggerType" : "PUSH"
}, {
"hash" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426",
"triggerID" : "11e20c0e55fc2502f5a2891a85ffe6c9a7024848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c51e8e28c5440500e4c2b8ff4ec606f222d56a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5389)
* 11e20c0e55fc2502f5a2891a85ffe6c9a7024848 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5426)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org