You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/07/30 13:50:28 UTC
[GitHub] [tinkerpop] WiredUK commented on issue #1172: Handle closed
connections gracefully instead of bubbling up exceptions
WiredUK commented on issue #1172: Handle closed connections gracefully instead of bubbling up exceptions
URL: https://github.com/apache/tinkerpop/pull/1172#issuecomment-516427412
> thanks for taking the time to contribute to the project. could you say some more about the performance issues - is there a noticeable improvement as a result of this change?
Sure Stephen, I don't have a huge amount of data, but I had a process that was taking around ~9-10s to complete and this change reduced it to ~6s. The process I was running ran approximately 12 Gremlin queries and each one threw at least 2 internal `NullReferenceException`'s, usually many more. My debug output looks something like this:
<details>
<summary>Log output</summary>
<p>
```
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.addV(label).<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.V().<Redacted>
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.addV(label).<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.addV(label).<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.addV(label).<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.V().<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Executing Gremlin: g.addV(label).<Redacted>
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
Exception thrown: 'System.NullReferenceException' in Gremlin.Net.dll
```
</p>
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services