You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "leeyspaul (via GitHub)" <gi...@apache.org> on 2026/04/24 05:14:59 UTC
[PR] Fix retrigger form config sync [airflow]
leeyspaul opened a new pull request, #65749:
URL: https://github.com/apache/airflow/pull/65749
Fixes the `Trigger again with this config` flow so edits made in `Run Parameters` stay synchronized with the JSON shown in `Advanced Options` and the config used on submit.
The root cause was that the prefilled re-trigger path initialized correctly, but later `conf` updates were not propagated back into the React Hook Form state after prefill had already been applied. This change keeps the initial prefill behavior and restores ongoing sync afterward. It also adds a regression test covering the prefilled re-trigger case.
Related: #65716
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Codex GPT-5
Generated-by: Codex GPT-5 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix retrigger form config sync [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #65749:
URL: https://github.com/apache/airflow/pull/65749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix retrigger form config sync [airflow]
Posted by "leeyspaul (via GitHub)" <gi...@apache.org>.
leeyspaul commented on PR #65749:
URL: https://github.com/apache/airflow/pull/65749#issuecomment-4316426869
> Can confirm fixes the problem! Thanks for the fix!
>
> Tests fail, can you please fix them? Then another UI maintainer review would be good, looking forward having this fixed in 3.2.2!
Thank you for catching that. :), I forgot to run the UI test suite before pushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix retrigger form config sync [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #65749:
URL: https://github.com/apache/airflow/pull/65749#issuecomment-4330979546
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org