You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Realtin (via GitHub)" <gi...@apache.org> on 2024/11/19 12:19:14 UTC

[PR] Log4j api test refactor junit5 (logging-log4j2)

Realtin opened a new pull request, #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218

   We are from Neighbourhoodie, the implementation partner of the [STF](https://www.sovereigntechfund.de/programs/bug-resilience) Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. 
   This PR migrates the tests located in log4j-api-test to JUnit5.
   
   ## Checklist
   
   * [x] Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise
   * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `./mvnw spotless:apply` and retry)
   * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` directory
   * Tests for the changes are provided
   * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Log4j api test refactor junit5 (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-2485981098

   @Realtin,
   
   I'll look into it tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Log4j api test refactor junit5 (logging-log4j2)

Posted by "Realtin (via GitHub)" <gi...@apache.org>.
Realtin commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-2485579789

   Hi @vy I ran into a problem after refactoring the SecurityManagerRule to an Extension. It seems to end up in a loop at: `LoaderUtilSecurityManagerTest$TestSecurityManager.checkPermission(LoaderUtilSecurityManagerTest.java:36)` 
   and ends with an error:
   
   ```
   org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException Error occurred in starting fork, check output in log
   [ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:456) .... 
   ```
   
   Do you have any pointers on how to solve this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migrate `log4j-api-test` to junit5 [logging-log4j2]

Posted by "Realtin (via GitHub)" <gi...@apache.org>.
Realtin commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-5766051038

   @ramanathan1504 you can go forward with it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migrate `log4j-api-test` to junit5 (logging-log4j2)

Posted by "grobmeier (via GitHub)" <gi...@apache.org>.
grobmeier commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-2563031915

   review in #1867 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migrate `log4j-api-test` to junit5 [logging-log4j2]

Posted by "ramanathan1504 (via GitHub)" <gi...@apache.org>.
ramanathan1504 commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-5712384411

   @Realtin still you are working on this or can go I forward with what ever you done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migrate `log4j-api-test` to junit5 [logging-log4j2]

Posted by "ramanathan1504 (via GitHub)" <gi...@apache.org>.
ramanathan1504 commented on PR #3218:
URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-5766384012

   > @ramanathan1504 you can go forward with it!
   
   Thanks👍🏾


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org