Re: Review Request 68090: Added log_auto_compact flag to the master.

[Mesos Reviewbot <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68090/#review213065
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68089, 68090]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 27, 2018, 1:12 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68090/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 1:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-184
>     https://issues.apache.org/jira/browse/MESOS-184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new flag enables experimental automatic compaction invocation for
> the LevelDB based replicated log storage. This is a workaround the
> problem described in for MESOS-184.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.hpp 3929c297b45e1203e5b00454e88f86988a8b1058 
>   src/master/flags.cpp 8fede0d2cf2254f34134329885f47c3c78dc5846 
>   src/master/main.cpp 2c7b1bb492a0655dec9280e98ff942a15e2ae8f0 
> 
> 
> Diff: https://reviews.apache.org/r/68090/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `make check`. Manually verified that the replicated log storage doesn't grow over time with `--log_auto_compact=true`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>